Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4397 to place ci.blt.yml by default. #4489

Merged
merged 5 commits into from
May 6, 2022

Conversation

mikemadison13
Copy link
Contributor

Motivation
BLT ships with a ci.yml file (see https://github.com/acquia/blt/blob/main/scripts/blt/ci/internal/ci.yml) but it no longer places it as ci.blt.yml in the blt folder.

Proposed changes
Place the file during the scaffolding process.

Testing steps

  1. Setup a new project using acquia/drupal-recommended-project
  2. Add BLT
  3. confirm that blt/ci.blt.yml is in place

@mikemadison13 mikemadison13 changed the title Fixes #4397 to place ci.blt.yml by defaul. Fixes #4397 to place ci.blt.yml by default. Mar 16, 2022
@mikemadison13
Copy link
Contributor Author

I'm getting a test failure here: https://github.com/acquia/blt/blob/main/tests/phpunit/src/DrupalSettingsTest.php#L41

$this->assertEquals($output_array['uri'], $drush_local_site_yml['options']['uri']);

This is failing with:

There was 1 failure:

1) Acquia\Blt\Tests\DrupalSettingsTest::testSetupDefaultLocalSettings
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'http://127.0.0.1:8080/'
+'http://127.0.0.1:8888/'

I think what's happening is that the ci.blt.yml file is resetting the value in the local.yml file (because we are in CI). I've updated the test to compare the local drush version output and the ci.blt.yml output to ensure they are the same. the drush status output is likely never going to show the 8888 port!

@mikemadison13 mikemadison13 force-pushed the 4397 branch 7 times, most recently from 2a83721 to 4ef5659 Compare March 23, 2022 18:50
@mikemadison13
Copy link
Contributor Author

FYI @danepowell i am experiencing test failures here and the values are flipped in PHP 7.4 and 8.0. i'm not sure what's going on, but i may need some help digging into it.

@mikemadison13 mikemadison13 force-pushed the 4397 branch 13 times, most recently from 714afd9 to f02ffc7 Compare March 28, 2022 16:15
@pavlosdan
Copy link
Contributor

This was what was missing to get our tests running in gitlab. +1 for creating the ci.blt.yml file during scaffolding. Or at the very list when the ci recipes or behat ini recipes runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants