Bail out when null values are encountered #369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invalid classes are encountered such as
P(a,0,c)
which result in null values being generated for some args (they are not custom values), we need to short-circuit the processing of the rest of the values. Can't short-circuit aforEach
loop, but can check fortreeo.declarations
being null before trying to reference it further.Background - This issue came up because of a recent change to Marko templating system. Marko generates code that looks a little like Atomic classes, but is actually obfuscated function calls. Normally these would be ignored due to the lack of valid "values" in the string, but they recently switched away from serializing
null
to using a0
value, which looks "valid" to Atomizer.marko-js/marko#1535