-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc perf improvements #1535
Merged
Merged
Misc perf improvements #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
=======================================
Coverage 90.51% 90.52%
=======================================
Files 352 353 +1
Lines 12645 12657 +12
=======================================
+ Hits 11446 11458 +12
Misses 1199 1199
Continue to review full report at Codecov.
|
mlrawlings
approved these changes
Mar 30, 2020
DylanPiercey
added a commit
that referenced
this pull request
Apr 13, 2020
* perf: attr & escape helper optimization * perf: optimize server component * perf: dynamic tag perf improvements * perf: prevent escaping json attrs, optimize nonce * perf: legacy widget & dynamic tag key serialization improvement * perf: prevent serializing component props for legacy components * fix: auto key regexp for dynamic tag * perf: prevent creating constructors for implicit components (cherry picked from commit ff82248)
DylanPiercey
added a commit
that referenced
this pull request
Apr 13, 2020
* perf: attr & escape helper optimization * perf: optimize server component * perf: dynamic tag perf improvements * perf: prevent escaping json attrs, optimize nonce * perf: legacy widget & dynamic tag key serialization improvement * perf: prevent serializing component props for legacy components * fix: auto key regexp for dynamic tag * perf: prevent creating constructors for implicit components (cherry picked from commit ff82248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of these performance improvements are targeted toward legacy components, however some also improve modern components.
Legacy widget improvements include:
null
for input, instead use0
.Modern component improvements include:
nonce
is added to scripts now uses the optimized double quote escape instead ofJSON.stringify
.data-marko-key
attributes output for split components.{
are JSON, and use single quotes.&
.Set
.Checklist: