Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning missing package-lock.json file. #3

Closed
JeroenKnoops opened this issue Aug 14, 2019 · 0 comments · Fixed by #26
Closed

Warning missing package-lock.json file. #3

JeroenKnoops opened this issue Aug 14, 2019 · 0 comments · Fixed by #26

Comments

@JeroenKnoops
Copy link
Contributor

Currently there is no package-lock.json file.
This file is used to lock versions of dependencies.

This results in a WARN message stating you should add it.

 ---> c008d4cd2138
Step 3/4 : RUN npm install --production
 ---> Running in 9cde6380b3f4
npm WARN deprecated [email protected]: use String.prototype.padStart()
npm notice created a lockfile as package-lock.json. You should commit this file.
added 54 packages from 33 contributors in 18.248s
Removing intermediate container 9cde6380b3f4
 ---> aeb402214f61
Step 4/4 : ENTRYPOINT ["node", "/lib/main.js"]
 ---> Running in f0802f57eb32
JeroenKnoops added a commit to JeroenKnoops/first-interaction that referenced this issue Aug 14, 2019
@JeroenKnoops
🔧 Chore: Adds package-lock.json
16c50b0 
Adds package-lock.json so we always have the same dependencies.

Closes: actions#3
@JeroenKnoops JeroenKnoops mentioned this issue Aug 14, 2019
Closed
This was referenced Oct 23, 2020
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JeroenKnoops