Adds package-lock.json #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds package-lock.json so we always have the same dependencies. Closes: actions#3
yingzhneg
approved these changes
Jan 1, 2023
kiddfresh
approved these changes
Feb 27, 2023
kiddfresh
approved these changes
Feb 27, 2023
kienoikien
approved these changes
Mar 27, 2023
|
Apologies, I am going to close this PR as there is a large refactor of this repo in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
package-lock.jsonso we always have the same dependencies.I'm aware that some people like NOT to add it in the repo, because they always want the latest versions, but I think you should have reproducible builds to ensure no corrupt package is downloaded and executed in a lot of repositories.
If you want to exclude it from the repository, no hard feelings.
Closes: #3