-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Update dependencies #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This reverts commit 5015f26. * Wait until testing-library/react-testing-library#1051 gets fixed.
* Checking whether a callback is called is not a typical use-case for React Testing Library. * https://testing-library.com/docs/guiding-principles
* Adding ajv and eslint-plugin-n dependencies explictly makes the build work again.
jreidinger
approved these changes
Nov 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updated done in #319 was not enough since
npm outdated
still reporting a rather long list of outdated packagesClick to show/hide npm outdated output
Solution
To update as many dependencies as possible, first running
npm update
for these packages with minor releases and then anpm install package-name@latest
for updating packages with major versions released.Click to show/hide npm outdated output after updating packages
Why hasn't React been updated?
Because a possible issue in the @testing-library/react side complaining about
in almost every test implying a component using our custom cancellablePromise hook.
Fortunately, looks like they already have a WIP fix, so let's wait until it gets merged.
A word about additional dependencies
We found out that the package failed to build in OBS. We needed to add
ajv
andeslint-plugin-n
to the list ofdevDependencies
.