Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Update dependencies #331

Merged
merged 14 commits into from
Nov 25, 2022
Merged

[web] Update dependencies #331

merged 14 commits into from
Nov 25, 2022

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Nov 23, 2022

Problem

Updated done in #319 was not enough since npm outdated still reporting a rather long list of outdated packages

Click to show/hide npm outdated output
Package                                Current        Wanted    Latest  Location                                       Depended by
@babel/core                             7.17.9        7.20.2    7.20.2  node_modules/@babel/core                       web
@babel/eslint-parser                    7.17.0        7.19.1    7.19.1  node_modules/@babel/eslint-parser              web
@babel/preset-env                      7.16.11        7.20.2    7.20.2  node_modules/@babel/preset-env                 web
@babel/preset-react                     7.16.7        7.18.6    7.18.6  node_modules/@babel/preset-react               web
@patternfly/patternfly                 4.219.2       4.221.2   4.221.2  node_modules/@patternfly/patternfly            web
@patternfly/react-core                 4.261.0       4.264.0   4.264.0  node_modules/@patternfly/react-core            web
@patternfly/react-table               4.111.33      4.111.45  4.111.45  node_modules/@patternfly/react-table           web
@testing-library/react                  12.1.4        12.1.5    13.4.0  node_modules/@testing-library/react            web
@testing-library/user-event             14.1.1        14.4.3    14.4.3  node_modules/@testing-library/user-event       web
@typescript-eslint/eslint-plugin        5.39.0        5.44.0    5.44.0  node_modules/@typescript-eslint/eslint-plugin  web
@typescript-eslint/parser               5.39.0        5.44.0    5.44.0  node_modules/@typescript-eslint/parser         web
babel-loader                             8.2.4         8.3.0     9.1.0  node_modules/babel-loader                      web
chrome-remote-interface                 0.31.2        0.31.3    0.31.3  node_modules/chrome-remote-interface           web
compression-webpack-plugin               9.2.0         9.2.0    10.0.0  node_modules/compression-webpack-plugin        web
copy-webpack-plugin                      9.1.0         9.1.0    11.0.0  node_modules/copy-webpack-plugin               web
core-js                                 3.21.1        3.26.1    3.26.1  node_modules/core-js                           web
css-loader                               6.7.1         6.7.2     6.7.2  node_modules/css-loader                        web
css-minimizer-webpack-plugin             3.4.1         3.4.1     4.2.2  node_modules/css-minimizer-webpack-plugin      web
eos-icons-react                          2.3.0         2.4.0     2.4.0  node_modules/eos-icons-react                   web
eslint                                  7.32.0        7.32.0    8.28.0  node_modules/eslint                            web
eslint-config-standard                  14.1.1        14.1.1    17.0.0  node_modules/eslint-config-standard            web
eslint-config-standard-jsx              10.0.0        10.0.0    11.0.0  node_modules/eslint-config-standard-jsx        web
eslint-config-standard-react            11.0.1        11.0.1    12.0.0  node_modules/eslint-config-standard-react      web
eslint-plugin-flowtype                  5.10.0        5.10.0     8.0.3  node_modules/eslint-plugin-flowtype            web
eslint-plugin-promise                    4.3.1         4.3.1     6.1.1  node_modules/eslint-plugin-promise             web
eslint-plugin-react                     7.29.4       7.31.11   7.31.11  node_modules/eslint-plugin-react               web
eslint-plugin-react-hooks                4.4.0         4.6.0     4.6.0  node_modules/eslint-plugin-react-hooks         web
eslint-plugin-standard                   4.1.0         4.1.0     5.0.0  node_modules/eslint-plugin-standard            web
eslint-webpack-plugin                    2.6.0         2.7.0     3.2.0  node_modules/eslint-webpack-plugin             web
jsdoc                                   3.6.10        3.6.11     4.0.0  node_modules/jsdoc                             web
mini-css-extract-plugin                  2.6.0         2.7.0     2.7.0  node_modules/mini-css-extract-plugin           web
po2json                           1.0.0-beta-3  1.0.0-beta-3     0.4.5  node_modules/po2json                           web
qunit                                   2.18.1        2.19.3    2.19.3  node_modules/qunit                             web
react                                   17.0.2        17.0.2    18.2.0  node_modules/react                             web
react-dom                               17.0.2        17.0.2    18.2.0  node_modules/react-dom                         web
react-router-dom                         6.3.0         6.4.3     6.4.3  node_modules/react-router-dom                  web
regenerator-runtime                     0.13.9       0.13.11   0.13.11  node_modules/regenerator-runtime               web
sass                                    1.50.0        1.56.1    1.56.1  node_modules/sass                              web
sass-loader                             12.6.0        12.6.0    13.2.0  node_modules/sass-loader                       web
sizzle                                   2.3.6         2.3.8     2.3.8  node_modules/sizzle                            web
terser-webpack-plugin                    5.3.1         5.3.6     5.3.6  node_modules/terser-webpack-plugin             web
typedoc                                0.23.15       0.23.21   0.23.21  node_modules/typedoc                           web
typescript                               4.8.4         4.9.3     4.9.3  node_modules/typescript                        web
webpack                                 5.72.0        5.75.0    5.75.0  node_modules/webpack                           web
webpack-cli                              4.9.2        4.10.0     5.0.0  node_modules/webpack-cli                       web

Solution

To update as many dependencies as possible, first running npm update for these packages with minor releases and then a npm install package-name@latest for updating packages with major versions released.

Click to show/hide npm outdated output after updating packages
Package                      Current        Wanted  Latest  Location                             Depended by
@testing-library/react        12.1.5        12.1.5  13.4.0  node_modules/@testing-library/react  web
po2json                 1.0.0-beta-3  1.0.0-beta-3   0.4.5  node_modules/po2json                 web
react                         17.0.2        17.0.2  18.2.0  node_modules/react                   web
react-dom                     17.0.2        17.0.2  18.2.0  node_modules/react-dom               web

Why hasn't React been updated?

Because a possible issue in the @testing-library/react side complaining about

console.error
Warning: An update to App inside a test was not wrapped in act(...).

in almost every test implying a component using our custom cancellablePromise hook.

Fortunately, looks like they already have a WIP fix, so let's wait until it gets merged.

A word about additional dependencies

We found out that the package failed to build in OBS. We needed to add ajv and eslint-plugin-n to the list of devDependencies.

@dgdavid dgdavid changed the title Update dependencies [web] Update dependencies Nov 24, 2022
@coveralls
Copy link

coveralls commented Nov 24, 2022

Coverage Status

Coverage increased (+0.03%) to 74.625% when pulling 64abaca on update-node-packages-ii into 49e6a2a on master.

@imobachgs imobachgs marked this pull request as ready for review November 24, 2022 20:33
* Adding ajv and eslint-plugin-n dependencies explictly makes the
  build work again.
@imobachgs imobachgs merged commit 23e58f5 into master Nov 25, 2022
@imobachgs imobachgs deleted the update-node-packages-ii branch November 25, 2022 08:51
@mvidner mvidner mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants