-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require NPM 18 #375
Require NPM 18 #375
Conversation
Ha!!
|
12ae906
to
ffb9175
Compare
@@ -4,7 +4,7 @@ | |||
# package. This script is supposed to run within a repository clone. | |||
|
|||
sudo zypper --non-interactive install gcc gcc-c++ make openssl-devel ruby-devel \ | |||
npm git augeas-devel cockpit jemalloc-devel || exit 1 | |||
'npm>=18' git augeas-devel cockpit jemalloc-devel || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ rpm -q --provides npm19
...
nodejs-npm = 19.1.0
npm = 19.1.0 # match here
npm(npm) = 8.19.3
npm19 = 19.1.0-1.1
npm19(x86-64) = 19.1.0-1.1
We spent some hours debugging a problem where the web frontend was not updated because the machine had NPM 17 which is no longer enough: For example a recent babel-jest wants node 18 (or specific 16 or 14) https://github.com/facebook/jest/blob/41bf2300895a2c00d0525d21260f0a392819871f/packages/babel-jest/package.json#L38 https://docs.npmjs.com/cli/v6/configuring-npm/package-json#config
ffb9175
to
9450ff3
Compare
Problem
We spent some hours debugging a problem where the web frontend was not updated because the machine had NPM 17 which is no longer enough
Solution
Tell zypper, and npm, to install v 18 at least
Testing
./setup.sh
with