Skip to content

Commit

Permalink
fix(ci): temporarily pin matrix to Node 16 on Ubuntu (#113)
Browse files Browse the repository at this point in the history
* update to use LTS Node 18

- Node 14 [fails to install](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139557?pr=112)
  - ```txt
    Run actions/setup-node@v3
    Attempting to download 14.x...
    Not found in manifest. Falling back to download directly from Node
    Error: Unable to find Node version '14.x' for platform darwin and architecture arm64.
    ```

- keep Node 16 for now, although it is out-of-support
  - ensure continuous range testing; should bump that later too

* try 16.x on Ubuntu only for now

- that one [passed](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139677)
- 18.x and other 16.x versions failed to install `node-canvas`, c.f. PR comment
  • Loading branch information
agilgur5 authored Dec 31, 2024
1 parent cb09cf7 commit a96c383
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
strategy:
matrix:
# TODO: add back Node 18 once node-canvas is properly supported: https://github.com/Automattic/node-canvas/issues/2025
node-version: [14.x, 16.x] # LTS Node: https://nodejs.org/en/about/releases/
os: [ubuntu-latest, windows-latest, macOS-latest]
node-version: [16.x] # LTS Node: https://nodejs.org/en/about/releases/
os: [ubuntu-latest]

steps:
- name: Checkout repo
Expand Down

0 comments on commit a96c383

Please sign in to comment.