fix(ci): temporarily pin matrix to Node 16 on Ubuntu #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
the
kind: internal
agilgur5
commented
Dec 31, 2024
There was a problem hiding this comment.
✅ CI passes now. Coverage was manually checked and Codecov check will need to be bypassed for now per #112 (comment)
agilgur5
force-pushed
the
fix-ci-temp-pin-node
branch
from
91f498c to
23638df
Compare
- Node 14 [fails to install](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139557?pr=112) - ```txt Run actions/setup-node@v3 Attempting to download 14.x... Not found in manifest. Falling back to download directly from Node Error: Unable to find Node version '14.x' for platform darwin and architecture arm64. ``` - keep Node 16 for now, although it is out-of-support - ensure continuous range testing; should bump that later too
- that one [passed](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139677) - 18.x and other 16.x versions failed to install `node-canvas`, c.f. issue comment
agilgur5
force-pushed
the
fix-ci-temp-pin-node
branch
from
23638df to
92e3185
Compare
agilgur5
added
the
scope: dependencies
agilgur5
added a commit
that referenced
this pull request
Jan 3, 2025
* update to use LTS Node 18 - Node 14 [fails to install](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139557?pr=112) - ```txt Run actions/setup-node@v3 Attempting to download 14.x... Not found in manifest. Falling back to download directly from Node Error: Unable to find Node version '14.x' for platform darwin and architecture arm64. ``` - keep Node 16 for now, although it is out-of-support - ensure continuous range testing; should bump that later too * try 16.x on Ubuntu only for now - that one [passed](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139677) - 18.x and other 16.x versions failed to install `node-canvas`, c.f. PR comment (cherry picked from commit a96c383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
node-version: [16.x]andos: [ubuntu-latest]for the CI matrix to get it to pass for nowDetails
node-canvasprebuilt binaries (and then fails to build).node-canvasper Add Node 18 prebuilds Automattic/node-canvas#2025 (comment), so hold off on that for a separate PR.For now, just get CI working on a single OS and Node version.
Notes to Reviewers