-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): update codecov-action
to v5
#114
Conversation
- per https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token, it seems a newer version is required now
Drilling into the coverage action's logs:
|
Ok according to https://docs.codecov.com/docs/codecov-tokens#tokenless-on-unprotected-branches, a "protected" branch is any "unprefixed" branch (has a name without a colon |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 75 75
Branches 9 9
=========================================
Hits 75 75 ☔ View full report in Codecov by Sentry. |
apparently according to https://docs.codecov.com/docs/codecov-tokens#enabling-tokenless-uploads-for-public-repositories, there is a setting to enable this, however the setting itself does not say "public repos only" confusingly....
one more correction, apparently it can work without tokens if you change a setting in Codecov. It's default on in newer Codecov orgs but off for older ones (mine's quite old). Confusingly though, this exact settings screen doesn't specifically say the setting only impacts "public repositories only" unlike the docs page 😕 : I did get it working with and without a token now though per the above comment from the Codecov bot and the passing GH check now. |
codecov-action
to v5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Codecov is working now
* fix(ci): update `codecov-action` for tokenless uploads - per https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token, it seems a newer version is required now * token is apparently needed for `main` and other "unprefixed" branches - c.f. https://docs.codecov.com/docs/codecov-tokens#tokenless-on-unprotected-branches * remove token and change Codecov settings apparently according to https://docs.codecov.com/docs/codecov-tokens#enabling-tokenless-uploads-for-public-repositories, there is a setting to enable this, however the setting itself does not say "public repos only" confusingly.... (cherry picked from commit 599f371)
Summary
Per #112 (comment) and https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token, it seems a newer version of the action is required now for tokenless uploads due to GH rate limiting etc
Details
codecov-action
fromv2
tov5
Notes to Reviewers