fix(ci): run GH action on external PRs as well

[agilgur5]

Summary

Add pull_request to GHA on config

Details

• push works for all PRs from my own branches, but not for PRs from forks from external contributors
  • see also agilgur5/mst-persist@c890d14

#110 and #111 are not running CI because this was missing per #109 (comment)

[agilgur5]

I figured the old Node versions might fail; for reference Node 14 fails to install:

Run actions/setup-node@v3
Attempting to download 14.x...
Not found in manifest. Falling back to download directly from Node
Error: Unable to find Node version '14.x' for platform darwin and architecture arm64.

I'd like to keep Node 16 for now, although it is EoL, to ensure continuous testing throughout the range. Will bump that later too.

Using 16.x and 18.x though it looks like node-canvas is again having install failures 😕 . From 16.x on macOS.

Run npm ci
[...]
npm ERR! node-pre-gyp info using [email protected] | darwin | arm64
npm ERR! node-pre-gyp info check checked for "/Users/runner/work/react-signature-canvas/react-signature-canvas/node_modules/canvas/build/Release/canvas.node" (not found)
npm ERR! node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.9.1/canvas-v2.9.1-node-v93-darwin-unknown-arm64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.9.1/canvas-v2.9.1-node-v93-darwin-unknown-arm64.tar.gz 
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v93 ABI, unknown) (falling back to source compile with node-gyp) 
npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.9.1/canvas-v2.9.1-node-v93-darwin-unknown-arm64.tar.gz

And with 18.x on Ubuntu:

npm error node-pre-gyp info using [email protected] | linux | x64
npm error node-pre-gyp info check checked for "/home/runner/work/react-signature-canvas/react-signature-canvas/node_modules/canvas/build/Release/canvas.node" (not found)
npm error node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.9.1/canvas-v2.9.1-node-v108-linux-glibc-x64.tar.gz
npm error node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.9.1/canvas-v2.9.1-node-v108-linux-glibc-x64.tar.gz 

Afaict, per Automattic/node-canvas#2025 (comment), this likely requires updating node-canvas.

As a less intrusive change, I'd like to try 16.x on Ubuntu, since that worked on a retry.
Can update Node + node-canvas to newer versions in a future PR then after that passes (for continuous range testing purposes, per above)

[agilgur5]

As a less intrusive change, I'd like to try 16.x on Ubuntu, since that worked on a retry.

Ok this is working for now. Codecov status check isn't reporting seemingly b/c the old main report doesn't exist anymore due to cache age (Missing Head Commit), but this change is CI-only (no source code) and can manually confirm that 100% test coverage remains

[agilgur5]

I split off the Node/OS version pinning to a separate PR #113 as it's independent of GH actions running on external PRs.

[agilgur5]

Codecov status check isn't reporting seemingly b/c the old main report doesn't exist anymore due to cache age (Missing Head Commit)

Hmm, this is still happening even with #113 being merged and CI running on the merged commit.
Codecov isn't listing the latest commit either, although it is seeing the PRs.

I think this is because Codecov seemingly no longer supports tokenless coverage report uploads? The docs and GH Action both require a token now?

EDIT: looks like there's some requirements for tokenless now

[agilgur5]

EDIT: looks like there's some requirements for tokenless now

Split out another PR to get this working: #114

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (599f371) to head (925daf9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           75        75           
  Branches         9         9           
=========================================
  Hits            75        75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agilgur5]

✅ CI checks all green now, see split PRs #113 and #114 for more details on the fixes that were necessary