Fix dry_run in BaseSubmissionController.

[t-reents]

@mbercx Just encountered a small bug when setting dry_run to True.

The submit_new_batch method fails when setting dry_run = True, as it attempts to index a set which raises a TypeError. This issue is fixed by converting the set to a list.

[mbercx]

Thanks @t-reents! Indeed, in b910171 I removed some logic that converted the extras_to _submit set into a list. 🤦

Probably a good idea to write some tests at some point. 😅

For this PR: Maybe we can just cast the set assigned to the extras_to_submit variable to a list directly on line 185 using list()? I don't think any of the logic afterwards relies on this being a set.

[t-reents]

For this PR: Maybe we can just cast the set assigned to the extras_to_submit variable to a list directly on line 185 using list()? I don't think any of the logic afterwards relies on this being a set.

Yes, I was thinking about the same but didn't check it further. Indeed, we only iterate it afterwards, so I'll cast it directly into a list.

Probably a good idea to write some tests at some point. 😅

Haha, I was actually thinking the same when I encountered this one, and wanted to touch base with you on this in the office 😄 Happy to help, but I might need some support when setting up the mocking data.

[mbercx]

Haha, I was actually thinking the same when I encountered this one, and wanted to touch base with you on this in the office 😄 Happy to help, but I might need some support when setting up the mocking data.

I should be back at the office tomorrow, happy to chat. 😄

[mbercx]

Thanks again @t-reents!