-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests cleanup #75
Tests cleanup #75
Conversation
9ffebab
to
7799f39
Compare
7799f39
to
5197f06
Compare
@@ -4,7 +4,7 @@ | |||
from setuptools import setup, find_packages | |||
|
|||
|
|||
install_requires = ['botocore>=1.4.0, <=1.4.73', 'aiohttp>=0.21.2'] | |||
install_requires = ['botocore>=1.4.0, <=1.4.28', 'aiohttp>=1.1.0'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jettify Does aiobotocore actually require aiohttp>=1.1.0? The service in which I would like to aiobotocore is stuck on aiohttp==0.22.5 until aio-libs/aiohttp#1180 is resolved. As far as I can tell there aren't any changes here that strictly require bumping the aiohttp version? Would it be possible to leave this alone? Or at least make it >=0.22.5?
@adamrothman aiobotocore should work with older version too. If tests passes with Will do testing and update of PR a bit later. |
Thanks @jettify that would be awesome. If bumping that dependency isn't required, far more people will be able to use this new version. |
new version released https://pypi.python.org/pypi/aiobotocore/0.0.6 |
No description provided.