Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests cleanup #75

Merged
merged 7 commits into from
Nov 19, 2016
Merged

Tests cleanup #75

merged 7 commits into from
Nov 19, 2016

Conversation

jettify
Copy link
Member

@jettify jettify commented Nov 16, 2016

No description provided.

@@ -4,7 +4,7 @@
from setuptools import setup, find_packages


install_requires = ['botocore>=1.4.0, <=1.4.73', 'aiohttp>=0.21.2']
install_requires = ['botocore>=1.4.0, <=1.4.28', 'aiohttp>=1.1.0']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jettify Does aiobotocore actually require aiohttp>=1.1.0? The service in which I would like to aiobotocore is stuck on aiohttp==0.22.5 until aio-libs/aiohttp#1180 is resolved. As far as I can tell there aren't any changes here that strictly require bumping the aiohttp version? Would it be possible to leave this alone? Or at least make it >=0.22.5?

@jettify
Copy link
Member Author

jettify commented Nov 17, 2016

@adamrothman aiobotocore should work with older version too. If tests passes with 0.22.5 I will change it to >=0.22.5. I just wanted to bump aiohttp since v1.0.0 available for a while.

Will do testing and update of PR a bit later.

@adamrothman
Copy link
Contributor

Thanks @jettify that would be awesome. If bumping that dependency isn't required, far more people will be able to use this new version.

@jettify jettify merged commit f26d5f8 into master Nov 19, 2016
@jettify
Copy link
Member Author

jettify commented Nov 19, 2016

new version released https://pypi.python.org/pypi/aiobotocore/0.0.6

@jettify jettify deleted the tests-cleanup branch January 21, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants