-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests cleanup #75
Merged
Merged
Tests cleanup #75
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9edab8d
close responses in tests
jettify ef2cdcc
update comment
jettify f438e0a
pin aiohttp version to aiohttp>=1.1.0
jettify 1234d78
update CHANGES.txt
jettify 5197f06
bump version to 0.0.6
jettify 8003e39
botocore version
jettify 41c3c6a
fix aiohttp aiohttp>=0.22.5
jettify File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jettify Does aiobotocore actually require aiohttp>=1.1.0? The service in which I would like to aiobotocore is stuck on aiohttp==0.22.5 until aio-libs/aiohttp#1180 is resolved. As far as I can tell there aren't any changes here that strictly require bumping the aiohttp version? Would it be possible to leave this alone? Or at least make it >=0.22.5?