Timeout on aquiring connection from pool #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Kuffa <[email protected]>
Signed-off-by: Michal Kuffa <[email protected]>
|
I'd love to provide some tests for this as well, but can't think of reasonable way. Any suggestions? Maybe connection to non-existent server with zero timeout would do the trick. |
Current coverage is 92.53% (diff: 100%)@@ master #218 diff @@
==========================================
Files 12 12
Lines 1338 1340 +2
Methods 0 0
Messages 0 0
Branches 168 168
==========================================
+ Hits 1238 1240 +2
Misses 73 73
Partials 27 27
|
|
Thank you for your contribution, but this change will break library for tornado users, for more information see: aio-libs/aiohttp#1180 |
|
Latest info related to timeout and aiohttp here: aio-libs/aiohttp#1524 Should this PR be updated to merge or closed? |
|
The PR should wait for Tornado 5 I think. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements timeout on acquiring connection from pool using the async-timeout lib. (#130)