Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timeout on acquiring connection from pool #766

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Implement timeout on acquiring connection from pool #766

merged 3 commits into from
Dec 14, 2020

Conversation

Pliner
Copy link
Member

@Pliner Pliner commented Dec 14, 2020

What do these changes do?

PR adds timeout for the acquiring a connection from the pool.

Are there changes in behavior for the user?

Pool.acquire will raise TimeoutError if no connection is returned from the pool in specified timeout.

Related issue number

Fixes #130, #218

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #766 (03be802) into master (b5d3490) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          13       13           
  Lines        1562     1563    +1     
  Branches      179      179           
=======================================
+ Hits         1451     1452    +1     
  Misses         79       79           
  Partials       32       32           
Impacted Files Coverage Δ
aiopg/__init__.py 100.00% <100.00%> (ø)
aiopg/pool.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d3490...03be802. Read the comment docs.

@Pliner Pliner marked this pull request as ready for review December 14, 2020 05:00
@Pliner Pliner requested a review from asvetlov December 14, 2020 05:10
@Pliner Pliner merged commit 29ab570 into master Dec 14, 2020
@Pliner Pliner deleted the fix-130 branch December 14, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement timeout on acquiring connection from pool
1 participant