Fix #133 (Docs is not building with node 16) #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #133 |
Call the function updateLinks() which references document (ie DOM) inside a `mounted` hook. Indeed the previous code was working with `yarn vuepress dev docs` but not with `yarn vuepress build docs` because when *building*, vue uses a server to generate the static website and usually `document` is only available on client side. However this is possible when inside the mounted hook (https://vuepress.vuejs.org/guide/using-vue.html#browser-api-access-restrictions) NB: no idea why this was working with node 14 though...
nhuet
force-pushed
the
nh/fix_doc_with_node16
branch
from
d53be3f
to
88cbc80
Compare
dbarbier
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call the function updateLinks() which references document (ie DOM)
inside a
mountedhook.Indeed the previous code was working with
yarn vuepress dev docsbutnot with
yarn vuepress build docsbecause when building, vue uses aserver to generate the static website and usually
documentis onlyavailable on client side.
However this is possible when inside the mounted hook
(https://vuepress.vuejs.org/guide/using-vue.html#browser-api-access-restrictions)
NB: no idea why this was working with node 14 though...