Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #133 (Docs is not building with node 16) #158

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fix #133 (Docs is not building with node 16) #158

merged 1 commit into from
Dec 14, 2021

Commits on Dec 13, 2021

  1. Fix airbus#133 (Docs is not building with node 16) 

    Call the function updateLinks() which references document (ie DOM)
inside a `mounted` hook.

Indeed the previous code was working with `yarn vuepress dev docs` but
not with `yarn vuepress build docs` because when *building*, vue uses a
server to generate the static website and usually `document` is only
available on client side.

However this is possible when inside the mounted hook
(https://vuepress.vuejs.org/guide/using-vue.html#browser-api-access-restrictions)

NB: no idea why this was working with node 14 though...
    @nhuet
    nhuet committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    88cbc80 View commit details
    Browse the repository at this point in the history