Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda package #114

Closed
shangxiao opened this issue Mar 7, 2021 · 8 comments
Closed

Conda package #114

shangxiao opened this issue Mar 7, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@shangxiao
Copy link
Contributor

shangxiao commented Mar 7, 2021

Thanks for a much needed way to run black over git diffs ❤️

Would it be possible to please get a conda package setup and uploaded to Anaconda.org?

Here are some instructions for creating a conda package from an existing pypi package: https://conda.io/projects/conda-build/en/latest/user-guide/tutorials/build-pkgs-skeleton.html

Actually it may be preferable to have it contributed to conda forge instead:

@akaihola akaihola self-assigned this Mar 8, 2021
@akaihola akaihola added the enhancement New feature or request label Mar 8, 2021
@akaihola akaihola added this to the 1.2.3 milestone Mar 8, 2021
@akaihola
Copy link
Owner

I started work on a Conda package, and will resume at some point. It seems that it all happens on the Conda repositories side, with no changes needed in the Darker repo.

akaihola added a commit that referenced this issue Mar 28, 2021
See  #114 (Conda package)
@akaihola
Copy link
Owner

akaihola commented Apr 3, 2021

My branch is here – I didn't yet create a pull request for it. Could you @shangxiao verify that I'm on the right tracks?

@shangxiao
Copy link
Contributor Author

I'm not 100% familiar with all the required settings for conda-forge but my cursory look at the recipe shows you're in the right direction 👍 When you submit the pull request to staged-recipes someone from the conda-forge group will give it a proper review and approve it if all's good.

@martinRenou
Copy link
Collaborator

Oh I didn't see you were working on this already, I opened a PR this morning: conda-forge/staged-recipes#14565

It seems that the installation fails on Windows though. Any idea why? Maybe running your CI on windows as well could be a good idea.

@akaihola
Copy link
Owner

@martinRenou running CI on Windows is a good idea. I don't work with Windows at all though, but I can see there are some examples and instructions in GitHub Actions / Guides / Building and testing Python.

Could you create a Darker issue on GitHub for this?

@akaihola
Copy link
Owner

For the record, Windows installation issues fixed by #121, and Windows test failures in #124.

@akaihola
Copy link
Owner

akaihola commented May 3, 2021

Let's make sure the Conda package for 1.2.3 is built and works before closing this issue and the 1.2.3 release milestone. See conda-forge/darker-feedstock#1.

@akaihola
Copy link
Owner

akaihola commented May 3, 2021

I verified that conda install -c conda-forge darker isort does install Darker 1.2.3. And the installed version does reformat code correctly. Thanks for your contribution @martinRenou!

@akaihola akaihola closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants