-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darker #14565
Add darker #14565
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/darker:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@akaihola I've added you as the committer, as I realised later that you started working on this on your side, I don't want to be stealing credit from you. Please confirm that you are willing to maintain this conda package :) |
Hi @martinRenou, I'd be happy to see someone else take responsibility for maintaining the conda package! So go ahead with it, no need to give attribution to me. Thanks for your effort! For reference, akaihola/darker#114 was the original issue for creating a conda package. |
|
||
build: | ||
# noarch: python | ||
skip: True # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the issue with Windows? Was it just that test -f
didn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently an installation issue on Windows akaihola/darker#120
At some point we might be able to make this package noarch, but due to this Windows issue we can't for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
akaihola/darker#120 has been merged and included in later versions – has this skip been removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it has been removed, you can see it here that the package is now noarch https://github.com/conda-forge/darker-feedstock/blob/main/recipe/meta.yaml#L13
Co-authored-by: Chris Burr <[email protected]>
Thanks for the review @chrisburr ! |
The Windows installation issue was fixed in akaihola/darker#121 (merged), and failing tests on Windows in akaihola/darker#124 (pending review). These fixes will be included in the next release (version 1.2.3). |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).