Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darker #14565

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Add darker #14565

merged 2 commits into from
Apr 20, 2021

Conversation

martinRenou
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/darker) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/darker) and found some lint.

Here's what I've got...

For recipes/darker:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/darker) and found it was in an excellent condition.

@martinRenou
Copy link
Member Author

@akaihola I've added you as the committer, as I realised later that you started working on this on your side, I don't want to be stealing credit from you.

Please confirm that you are willing to maintain this conda package :)

@akaihola
Copy link
Contributor

Hi @martinRenou,

I'd be happy to see someone else take responsibility for maintaining the conda package! So go ahead with it, no need to give attribution to me. Thanks for your effort!

For reference, akaihola/darker#114 was the original issue for creating a conda package.

recipes/darker/meta.yaml Outdated Show resolved Hide resolved

build:
# noarch: python
skip: True # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue with Windows? Was it just that test -f didn't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently an installation issue on Windows akaihola/darker#120

At some point we might be able to make this package noarch, but due to this Windows issue we can't for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

akaihola/darker#120 has been merged and included in later versions – has this skip been removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it has been removed, you can see it here that the package is now noarch https://github.com/conda-forge/darker-feedstock/blob/main/recipe/meta.yaml#L13

@martinRenou
Copy link
Member Author

Thanks for the review @chrisburr !

@chrisburr chrisburr merged commit 5dc4a11 into conda-forge:master Apr 20, 2021
@martinRenou martinRenou deleted the add_darker branch April 20, 2021 11:07
@akaihola
Copy link
Contributor

akaihola commented Apr 24, 2021

The Windows installation issue was fixed in akaihola/darker#121 (merged), and failing tests on Windows in akaihola/darker#124 (pending review). These fixes will be included in the next release (version 1.2.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants