Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Challenge 4 🦞 #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kiliancm94
Copy link

Fix the Bug Submission Pull Request

What was the bug?

When adding atomic transactions the signer parameter was sent as an Account when it needs a TransactionSigner.

How did you fix the bug?

By reading the documentation I have found a method to get the Transaction Signer from the Account.
https://github.com/algorandfoundation/algokit-utils-ts/blob/main/docs/capabilities/transaction.md#signing
Therefore, I have updated the code to fix the issue.

const senderTransactionSigner = algokit.getSenderTransactionSigner(sender)

const atc = new algosdk.AtomicTransactionComposer()
atc.addTransaction({txn: ptxn1, signer: senderTransactionSigner})
atc.addTransaction({txn: ptxn2, signer: senderTransactionSigner})

Console Screenshot:

Captura de pantalla 2024-03-29 a las 10 35 42

@iskysun96 iskysun96 added the Approved ✅ Successfully completed the challenge! label Apr 1, 2024
@iskysun96
Copy link
Contributor

🎉 Congrats on solving the 4th Algorand Coding Challenge!

I have labeled your PR approved, so you can now claim your certificate.

You can claim your certificate of completion NFT here:
https://goplausible.xyz/claim/8x3aqnmh7p2wf25dvmxz7ksvjs3gr02d6648tf31ny90wwtams53jvssjwcj2bgfs7qr425958h3abw83a33t3tdbqb0sjtntmta82r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ Successfully completed the challenge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants