Black and workflow rework #12

alinabuzachis · 2023-05-02T17:08:47Z

No description provided.

rds_instance: fix promotion_tier type SUMMARY Change promotion_tier type to integer ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell

…ies (ansible-collections#1511) s3_bucket - Ensure public_access settings are configured before policies SUMMARY At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This uncovered a race condition where we set the policy before setting the public_access configs. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

Bulk migration to Python 3.6 f-strings (1) SUMMARY We've dropped support for Python < 3.6, be more consistent with out code formatting and move to fstrings. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/ tests/unit/ ADDITIONAL INFORMATION deliberately skips the RDS modules (slow & flakey) module_utils (triggers a lot of integration tests) inventory plugins (currently flakey) Reviewed-by: Alina Buzachis

SUMMARY We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup A combination of black --preview flynt some manual cleanup ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/ tests/unit/ ADDITIONAL INFORMATION This PR is specifically targetting the RDS related modules. There's still more to come...

* Fix version_added Signed-off-by: Alina Buzachis <[email protected]> * Update Signed-off-by: Alina Buzachis <[email protected]> * Not backported --------- Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Mark Chappell <[email protected]>

…ansible-collections#1518) Flag RSA example in unit test to be ignored by GitLeaks SUMMARY The example in the unit test keeps triggering GitLeaks, flag to be ignored by GitLeaks (it's a fake) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_key ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Alina Buzachis

…llections#1525) Update changelog with the amazon.aws 5.5.0 and 4.5.0 info SUMMARY Update changelog with the amazon.aws 5.5.0 and 4.5.0 info ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell

…tions#1526) aws_ec2 inventory - migration to Python 3.6 f-strings SUMMARY We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup A combination of black --preview flynt some manual cleanup ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

ec2_vpc_endpoint - test flake SUMMARY Test was assuming that an endpoint we might not have created had no routes attached. This makes the test flaky when things are run in parallel. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_endpoint ADDITIONAL INFORMATION Routes (existence or not) are tested in later tests where we know which endpoint we're looking at. Reviewed-by: Alina Buzachis

Add flake8 and black to tox.ini SUMMARY Added linters env to tox.ini. As suggested here we need not backport this update. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis

* Fstring cleanup We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup A combination of * `black --preview` * `flynt` * some manual cleanup * changelog --------- Co-authored-by: Alina Buzachis <[email protected]>

We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup A combination of * `black --preview` * `flynt` * some manual cleanup Co-authored-by: Alina Buzachis <[email protected]>

backup_selection* new modules SUMMARY Part of this PR ansible-collections#1446 ISSUE TYPE New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis

…sible-collections#1535) module_utils/backup - explicitly pass resource to get_backup_tags SUMMARY We've currently got some nasty hacks being used that rewrite module.params. Explicitly pass the resource ID in, it's better when we're working on ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/backup ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

…r than CamelCase (ansible-collections#1536) backup_selection_info - ensure result is returned as snake_case rather than CamelCase SUMMARY backup_selection_info - ensure result is returned as snake_case rather than CamelCase ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell

Add backup_plan and backup_plan_info modules SUMMARY These three modules add capability to manage all configurations related to backups on AWS. ISSUE TYPE New Module Pull Request COMPONENT NAME backup_vault backup_plan backup_selection ADDITIONAL INFORMATION We've been using these three modules for 6 months now in our AWS estate, I thought it might be useful for others. I know that this is not the repo for public contribution, but as there is already work being done on this area here, I think it still make sense to have a look on the code, I tried to be as comprehensive as possible. No worries if it doesn't make into the main branch, feel free to cherry pick parts of it. Reviewed-by: Mark Chappell Reviewed-by: krisek Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <[email protected]>

Prep amazon.aws 6.0.0 release SUMMARY Prep amazon.aws 6.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: GomathiselviS Reviewed-by: Mike Graves <[email protected]>

Add Github Action details to CI.md SUMMARY We have the CI jobs from Zuul to GithubActions. This PR adds the documentation related to CI. ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis

Fix 6.0.0 changelog formatting SUMMARY Fixes bad formatting in 6.0.0 changelog ISSUE TYPE Docs Pull Request COMPONENT NAME CHANGELOG.rst changelogs/changelog.yaml ADDITIONAL INFORMATION

* Rename core collection Rename references to ansible.amazon to amazon.aws. * Rename community.amazon to community.aws Fix pep8 line lengths for rewritten amazon.aws imports * Missed a path in shippable.sh * Dependency repos moved This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@235c5db

alinabuzachis changed the title ~~Back and workflow rework~~ Black and workflow rework May 2, 2023

alinabuzachis force-pushed the back_and_workflow_rework branch 10 times, most recently from f0af9b5 to 89c6763 Compare May 2, 2023 18:20

gootdude and others added 19 commits May 4, 2023 08:59

Fstring cleanup (ansible-collections#1529)

8c0880b

We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup A combination of * `black --preview` * `flynt` * some manual cleanup Co-authored-by: Alina Buzachis <[email protected]>

backup_selection* new modules (ansible-collections#1530)

6bfdbda

backup_selection* new modules SUMMARY Part of this PR ansible-collections#1446 ISSUE TYPE New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis

Prep amazon.aws 6.0.0 release (ansible-collections#1537)

d72b87f

Prep amazon.aws 6.0.0 release SUMMARY Prep amazon.aws 6.0.0 release ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: GomathiselviS Reviewed-by: Mike Graves <[email protected]>

Fix 6.0.0 changelog formatting (ansible-collections#1542)

dec608f

Fix 6.0.0 changelog formatting SUMMARY Fixes bad formatting in 6.0.0 changelog ISSUE TYPE Docs Pull Request COMPONENT NAME CHANGELOG.rst changelogs/changelog.yaml ADDITIONAL INFORMATION

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Black and workflow rework #12

Black and workflow rework #12

alinabuzachis commented May 2, 2023

Black and workflow rework #12

Black and workflow rework #12

Conversation

alinabuzachis commented May 2, 2023