Fix Issue #45 "Reapers don't require tech lab anymore" #46
Conversation
| @@ -209,7 +209,6 @@ sc2::UnitTypeData Observer::GetUnitTypeData(sc2::UNIT_TYPEID id_) const { | |||
| break; | |||
|
|
|||
| case sc2::UNIT_TYPEID::TERRAN_MARAUDER: | |||
| case sc2::UNIT_TYPEID::TERRAN_REAPER: | |||
| data.tech_requirement = sc2::UNIT_TYPEID::TERRAN_BARRACKSTECHLAB; | |||
There was a problem hiding this comment.
Unfortunately, this patch is not enough.
You should move the reaper ability from here
suvorov-bot/src/blueprints/Blueprint.cpp
Line 106 in cf3bdf5
to here:
suvorov-bot/src/blueprints/Blueprint.cpp
Line 101 in cf3bdf5
There was a problem hiding this comment.
Thank you!
Currently we have a lot of intermediate changes in the history. Please squash the commits and I'll merge the request.
There was a problem hiding this comment.
Squashed and force-pushed. :)
src/blueprints/Building.cpp
Outdated
| point.x = base.x + sc2::GetRandomScalar() * 15.0f; | ||
| point.y = base.y + sc2::GetRandomScalar() * 15.0f; | ||
|
|
||
| offset.x = sc2::GetRandomScalar() * range; //build in range of StartLoc |
There was a problem hiding this comment.
I would suggest to try the approach used in CommandCenter.
The mineral line in the starting location is enclosed into a rectangle, if a building point is in the rectangle, different value is used. However, such approach requires careful detection of mineral lines which could be done in
Line 19 in 1fb4e7e
There was a problem hiding this comment.
Also we can use the placement grid abstraction from the api and mark the related tiles as occupied.
There was a problem hiding this comment.
I will look at that. I've reverted that commit, so the Reaper fix can be accepted while I work on this.
|
Thank you! LGTM. |
Removes REAPER from BARRACKSTECHLAB case in API.cpp's tech_requirement workaround.
Tested building Reapers without a BarrackTechLab and it works now.