Add the possibility to add a logo on a finder #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,10 @@ def beta? | |||
| content_item.details.beta | |||
| end | |||
|
|
|||
| def logo | |||
| content_item.details.logo | |||
There was a problem hiding this comment.
Since you're just calling content_item.details.logo here, you can add it to the delegate section at the top of the class.
There was a problem hiding this comment.
Uhm... will do, thanks Tommy.
jackscotti
changed the title
This was referenced Apr 23, 2015
jackscotti
changed the title
jackscotti
changed the title
issyl0
force-pushed
the
add_eu_logo_to_esif_funds
branch
2 times, most recently
from
5a4cd12
to
be6ee03
Compare
boffbowsh
force-pushed
the
add_eu_logo_to_esif_funds
branch
from
be6ee03
to
7ee8e02
Compare
European Structural and Investment funds must comply with EU legislations and they therefore need to display the EU logo. Quote from the legislation: "the Union emblem and the reference to the Union shall be visible, when landing on the website, inside the viewing area of a digital device, without requiring a user to scroll down the page".
boffbowsh
force-pushed
the
add_eu_logo_to_esif_funds
branch
from
7ee8e02
to
2fa2eec
Compare
boffbowsh
changed the title
tommyp
added a commit
that referenced
this pull request
Apr 30, 2015
Add the possibility to add a logo on a finder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
European Structural and Investment funds must comply with EU legislations and they therefore need to display the EU logo.
Quote from the legislation: "the Union emblem and the reference to the Union shall be visible, when landing on the website, inside the viewing area of a digital device, without requiring a user to scroll down the page".