This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Add EU logo_path to finders schema #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackscotti
changed the title
jackscotti
changed the title
| "beta_message": null, | ||
| "document_noun": "call", | ||
| "email_signup_enabled": false, | ||
| "eu_logo_path": "European Structural and Investment Funds", |
There was a problem hiding this comment.
Shouldn't this be european-structural-investment-funds.gif?
There was a problem hiding this comment.
thank you for picking this up!
So... it will be a path, but we don't know what the path will be yet. I'll fix this asap the file will have been uploaded.
issyl0
force-pushed
the
add_eu_logo_path_to_finders_schema
branch
3 times, most recently
from
0d7b79d
to
81e716d
Compare
- Some finders will be required to comply with EU legislations and will need to display a logo.
issyl0
force-pushed
the
add_eu_logo_path_to_finders_schema
branch
from
81e716d
to
bbdee2a
Compare
|
I've just rebased this onto master and fixed conflicts, edited |
|
Thank you all. I'd say, let's get this merged asap we know that alphagov/finder-frontend#189 works fine in dev environment. |
tommyp
added a commit
that referenced
this pull request
Apr 29, 2015
Add EU logo_path to finders schema
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
European Structural and Investment funds must comply with EU legislations and they therefore need to display the EU logo.
Quote from the legislation: "the Union emblem and the reference to the Union shall be visible, when landing on the website, inside the viewing area of a digital device, without requiring a user to scroll down the page".
ticket:
https://www.pivotaltracker.com/story/show/92225774
linked to:
alphagov/finder-frontend#189
alphagov/specialist-publisher#474