Fixes for header fallback 'crown' PNG #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses two issues flagged by the HTML5 validator.
Error: Element image is missing required attribute height.
From line 73, column 13; to line 73, column 117
<image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag
Error: Element image is missing required attribute width.
From line 73, column 13; to line 73, column 117
<image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag
Fixes #1298
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1419
NickColley
approved these changes
Jun 3, 2019
|
@NickColley happy with the changelog entry? |
|
@36degrees looks good to me 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues with the fallback 'crown' PNG in the header, which is displayed in browsers that don't support SVG (like IE8)
Before:
After:
