-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-arch image(amd64 and s390x) build and publish #23
Conversation
Thanks, @barthy1 This looks really big change ! I don't have other environments (such as s390x), how can I verify your change? |
hey @ozbillwang, thank you for quick response. Which part you would like to verify? You can also have a look to my dockerhub with multi-arch image I built using the PR code https://hub.docker.com/repository/docker/barthy/git/tags?page=1 |
…t image - build script was extended to build and publish images with arch information in tag (based on TRAVIS_CPU_ARCH env variable value), default is amd64 - in build script NEXT_TAG is generated only for amd64, because container image to get the value is amd64 only - alpine/semver:5.5.0. For s390x this value is stored in Travis workspace (or local file called tag.txt) - git push will work for amd64 only (to avoid push duplicates) - multi-arch-image script was added to create and push multi-arch manifest to dockerhub, joining together separate images for different architectures. At this moment amd64 and s390x are added. - Travis configuration file was extended to have 3 stages: - build amd64 images - build s390x images - generate multi-arch images based on previous stages - workspace usage was added to Travis config to persist NEXT_TAG data, as this value can be received only for amd64 case. s390x is just used it after from workspace tag.txt file Signed-off-by: Yulia Gaponenko <[email protected]>
can you share your travis build link? Try to access this url https://travis-ci.org/github/barthy1/git, but failed. |
Seems its build is similar as normal linux. Let me think if I can add a test, for example, use the latest build git image for s390, show git versionn and git clone a repo |
It would be great, thank you. Please let me know if I can help. |
hey @ozbillwang any updates or ideas how I can help? |
hi @ozbillwang just want to check if this PR is still on the table? Please, let me know, if I need to change/update/add something. |
Thanks for reminding. I am not that confidence to support this feature. I pop an idea to add you with write permission as maintainer in this rep, are you fine for this. In the future, any bugs/features about Multi-arch, you can help to support me? I added you in Linkedin, please accept and share me your mailbox. update 1Wait, I doesn't need your mailbox, I can add your account directly in github, let me try update 2Invitation has been sent to you. |
@ozbillwang I am ok to support you with multi-arch bugs/features for https://github.com/alpine-docker/git |
So, do you feel that this PR can be merged? |
Yes, let's merge it. |
Please review the build jobs, they are fine, but just double check |
I reviewed the build jobs, lgtm. |
The updates:
information in tag (based on TRAVIS_CPU_ARCH env variable value),
default is amd64
container image to get the value is amd64 only - alpine/semver:5.5.0.
For s390x this value is stored in Travis workspace (or local file called
tag.txt)
manifest to dockerhub, joining together separate images for different
architectures. At this moment amd64 and s390x are added.
as this value can be received only for amd64 case. s390x is just used it
after from workspace tag.txt file
Tested for master branch path in Travis