Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding POWER(ppc64le) architecture support #26

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

bahetiamit
Copy link
Contributor

This change adds the support for POWER (ppc64le) architecture to the image. This was tested on master branch in travis. This is an extension to #23

@barthy1
Copy link
Contributor

barthy1 commented Sep 22, 2020

Hi @bahetiamit ! Thank you for this PR.
Could you please share Travis build logs and link to the multi-arch image you got after the build?

@barthy1 barthy1 self-assigned this Sep 22, 2020
@bahetiamit
Copy link
Contributor Author

@barthy1

Please find the travis logs at - https://travis-ci.org/github/bahetiamit/git/builds/729545845 and travis built images at - https://hub.docker.com/repository/registry-1.docker.io/bahetiamit/git/tags?page=1

@barthy1
Copy link
Contributor

barthy1 commented Sep 23, 2020

hey @ozbillwang
I've verified that proposed code adds ppc64le arch to multi-arch apline/git images.
I also verified that resulted ppc64le image is buildable and runnable for according arch. No changes are introduced for s390x or amd64 builds.

Are you ok to merge this code?

@ozbillwang
Copy link
Contributor

Thanks, @barthy1

I am fine for the change. Let's merge it.

Please confirm if you can merge it directly.

@barthy1 barthy1 merged commit 5c1e8a6 into alpine-docker:master Sep 23, 2020
@snehlatamohite
Copy link

@bahetiamit @barthy1 - Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants