Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a builder class for the Lift class. #21

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

maxrossi91
Copy link

@maxrossi91 maxrossi91 commented Dec 15, 2021

I did two major change and one minor changes to help the usability of the library in external projects.

  • Created a builder class for the Lift class. (major)
    The builder class handle the bitverctors that were handled in the LiftMap class. The Lift class can now be also build from the builder class. This allows the decoupling of the construction of the Lift class
  • Updated serialize and load for compatibility with sdsl. (major)
    Now the load and serialize can be used in the same contest as the ones from sdsl.
  • Bugfix: The memcpy in the update_cigar function was causing memcpy-param-overlap errors when turning on ASAN. (major). See PR.
  • Included an option flag to avoid the definition and the construction of test targets. (minor)

@maxrossi91
Copy link
Author

I synced my fork with master, so now the conflicts are resolved.

I also included a fix for a problem when running leviosam with ASAN causing a memcpy-param-overlap error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant