Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memcpy-param-overlap #3

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Fix memcpy-param-overlap #3

merged 1 commit into from
Mar 4, 2023

Conversation

maxrossi91
Copy link
Owner

The memcpy in the update_cigar function was causing memcpy-param-overlap errors when turning on ASAN.

As a solution the memcpy was safely removed since the function was copying some parts of the qname component of data at aln->data + (n_cigar4 - fake_bytes) + 8 into the block including the cigar_st which will be overwritten in a later step.

@maxrossi91 maxrossi91 self-assigned this Mar 4, 2023
@maxrossi91 maxrossi91 merged commit baeb0af into master Mar 4, 2023
@maxrossi91 maxrossi91 deleted the bugfix/memcpy-param-overlap branch March 4, 2023 11:52
@maxrossi91 maxrossi91 mentioned this pull request Mar 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxrossi91 maxrossi91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxrossi91