-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Users to Preview Fonts within the Font Dropdown #3317
Comments
Related: #3301 |
Some ideas:
|
Well there is a reason why I put the screenshots here. The dialog even has a section for 'My fonts'. I think users want to be able to filter between, uploaded fonts, system fonts and google fonts. I would say filtering by type of font is pretty useful.
I tried to generate the SVGs but couldn't work out a scalable way of doing it on build. Also the SVGs do not reflect what the font looks like in the browser. Google docs doesn't use SVGs for that reason.
I have suggested this before, listing of a smaller group of say 25 / 30 font that are popular and look good. This is for people that quickly want to find a font ( or maybe don't really care about fonts ) without hunting around for special font. |
It seems very useful to list a smaller group of 30 popular google fonts. It also seem useful to offer system fonts. Do we think this is worth consideration as a solution to this ticket or am I going out of scope here? @spacedmonkey |
For the preview, Google docs loads the font, but only with the characters needed to display the preview. That improves performance and we should try it too. |
So I looked into just loading the characters we needed to preview here. But what ended up happening, was that I loaded say Again, this is why UX is the most improve test step here. @cathibosco can you do that mockup please? How is a popular font selected? Is it just the ones we had before in the dropdown? |
I spent a little time prototype what this interface could look like. It returns the font selection to a dropdown. By default it show 'popular' fonts when the dropdown is selected. The search, searches all fonts. https://www.youtube.com/watch?v=TUm5kZr-axE&feature=youtu.be Above is a mockup. |
Okay, so I see you have basically see what you have done here is just got the google font picker / manager into the story editor context. I think this is a good jumping off point, as I am sure that Google docs team put a lot of thought and testing into this dialog. Some thoughts off the bat.
Recent fonts in this story would be pretty simple, as it just means scanning the current story pages for text elements and making a list. But the other two options would require story a popular fonts list at a global or user level. How is that stored and how is that managed, are questions we would need to answer here.
Worth noting that many of the existing text blocks do not support font selection. See #3224 |
I made a dummy UI (just in the browser, no code behind it) to illustrate my thoughts about how this could work. I don't know about the last sub-menu, but it could for instance have further submenus for each letter or similar. It could also easily be dropped. The other three submenus (Custom, Native and Popular Google) could also just be a list directly in the component as Google Docs does it - similar to the "Used in this story" list right above. I think that will make it clear, that it's a list of popular fonts, as it obviously doesn't show all 1000+ fonts. The idea is, that if you search, the other items below are replaced by search results, but with an option at the top to clear search easily and see the regular options again. I don't know if the small category labels are required, but I like them 😄 – also intended for search results. And adding another category to indicate Typekit, etc would be trivial. |
Good work @barklund I really like the mockup. The little labels are cool and useful. I think we should keep them for future designs as they are super useful. This mockup does solve the problem of filter different types of font, like native, google and custom. But doesn't solve the other problem of discovery of fonts. This designs still really depends on you knowing the name of the google font you wish to use. What if I don't know what I want or even the style. I am want to feel out the design by checking out what types of fonts are available. Then you are back to scroll through the long list of fonts again. The one thing I am trying to avoid is massive long scrollbars of fonts. I know we are not currently supporting mobile, just desktop users, but can we try and design something with mobile / touch in mind, so that in the future we can easily add mobile support. I don't want us to design something now with just desktop in mind and then have to redesign it later when do want to support mobile. |
@cathibosco per our group sync on Monday this needs UX exploration. I am unable to assign to Sam currently in GitHub. Can you work with Sam to take a stab at the UX exploration here, and determine best path forward. Once done, I can add acceptance criteria. |
The UX team reviewed this closely and we will also review with Vamsee. Our recommendation is using the Google Docs model but the styles from the block editor. I dropped a low-fi screenshot of Google Doc font selection into the mock up above - but it will need to have the styles from Gutenberg UI.
|
This is a change in existing behavior. Currently text can have no font set and it will fallback to whatever is setup in the theme. This would not be |
IIRC the default is not theme-specific, but based on the system font ( |
Default is better than none - thank you for explaining the current existing conditions @swissspidy and @spacedmonkey |
Being able to set the default font is a great options for users, and potentially a higher priority than custom fonts for a majority of users, especially since we have all Google Fonts available. |
Guternberg team are looking into another accessible select menu. See detail here WordPress/gutenberg#17926 . This PR uses downshift. An example of which you can see here. See need to discussion if we are also going to implement downshift or go our own route with this piece of work. |
After a design review: Default to Arial. Here is a low-fidelity mock up - wanted to get this info to everyone as quickly as possible since we are blocking engineering. |
I am a litte confused by the mock ups. Can a user still search for google fonts? Or we just saying these fonts? |
Isn't this what we started with before adding all the google fonts 2 months ago? This doesn't really seem like progress, but might just reflect that the move to having all fonts available wasn't properly thought through in the first place. |
An editor should be able to enter the name of their desired Google font.... to use it. From Sam:
|
We have released the version of that allowed users to pick from 1000 fonts. I know we are still in beta but it not a good move to remove functionality that user may be using currently.
In the mockups it looks like you are converting it from a text search field to a dropdown. How will users enter the name of their desired google font? How do we make it clear that is the field is a combo text field and select dropdown.
This isn't clear to me what exactly this mean. Can you explain in more detail.
Where and by who is this list defined? |
Correct, we do not want to remove that functionality to pick form 1000s... Is it possible to preview the short list like Google Docs does while allowing for the search? |
Do we have "look ahead" or "auto populate" available? Yes we do, for some reason it was not displaying well on my site a while back. It is now. |
@swissspidy @cathibosco @jasti @spacedmonkey Hi folks. See the attached mocks for an interim solution to the font picker. Jonny, let us know if this is all doable. In short we would like to
|
I did some prototyping when this ticket was created. Funnily enough my prototype is very similar to the above. So you can see this prototype in action in this video https://www.youtube.com/watch?v=wHBzpA25w8k&feature=youtu.be Some key differences.
I would like some feedback on this prototype. |
Feature description
As a user I want to be able to see a preview of the font selections within the font dropdown in the stories editor.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: