Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency accessible-autocomplete to v2 #3351

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 26, 2019

This PR contains the following updates:

Package Type Update Change
accessible-autocomplete devDependencies major 1.6.2 -> 2.0.1

Release Notes

alphagov/accessible-autocomplete

v2.0.1

Compare Source

Fixes

v2.0.0

Compare Source

We recommend you update to the latest release using npm:

npm install accessible-autocomplete@latest

Breaking changes

You must make the following change when you migrate to this release, or your service may break.

Migrate to the new accessible focus state

The focus state now meets the new WCAG 2.1 level AA requirements.

You do not need to do anything if you’re using Sass.

If you’ve previously copied CSS from our code into your project, you must copy all the CSS from our accessible-autocomplete.min.css file into your CSS file.

If you’ve created custom CSS, you should check that your component meets WCAG 2.1 level AA requirements. You can read how we made the GOV.UK Design System focus states accessible.

Pull request #​360: Update focus styles to meet WCAG 2.1 level AA non-text contrast requirements.

Fixes
Better compatibility with screen readers

The input field is now visible to all screen readers, because the input field now meets the Accessible Rich Internet Applications (ARIA) 1.0 standard instead of ARIA 1.1. ARIA 1.0 is better supported by the current versions of most screen readers.

Screen readers will now consistently tell users:

  • when users have entered too few characters in the input field
  • the correct number of search results, and what the results are
  • which result users have highlighted
  • how to use autocomplete in different screen readers - by reading hidden hint text

Screen readers will also now avoid telling users information they do not need to know after they highlight an option.

Thanks to Mark Hunter, Chris Moore and everyone at HMRC who worked on these improvements.

Pull request #​355: Refinements to address accessibility issues


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@googlebot googlebot added the cla: yes Signed the Google CLA label Sep 26, 2019
@spacedmonkey
Copy link
Contributor

2.0.0 of autocomplete is a breaking change and will require a lot testing to make sure it works. I also already found an issue with autocomplete markup, documented here.

I think we should tackle this after #3317

@swissspidy
Copy link
Collaborator

Sounds good, let's wait.

@renovate-bot renovate-bot force-pushed the renovate/accessible-autocomplete-2.x branch 3 times, most recently from 1187507 to bf98143 Compare October 7, 2019 12:30
@renovate-bot renovate-bot force-pushed the renovate/accessible-autocomplete-2.x branch 2 times, most recently from faf82d1 to f113b30 Compare October 16, 2019 07:54
@renovate-bot renovate-bot force-pushed the renovate/accessible-autocomplete-2.x branch from f113b30 to 5a7988b Compare October 24, 2019 14:01
@swissspidy swissspidy closed this Nov 29, 2019
@forking-renovate
Copy link

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 2.x releases. However, if you upgrade to 2.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate-bot renovate-bot deleted the renovate/accessible-autocomplete-2.x branch November 29, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants