Svg check for large files #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnderbergE
commented
Jul 27, 2018
AnderbergE
commented
- Big svg files will not have a complete first chunk to check for end tag in the svg, hence it is not possible to use isSvg.
- Updated file-type to latest version to get more correct file types.
- New test for the more common svg file type. That starts with an xml version and doctype.
|
Argh, git is messing up the line endings making the size vary... Maybe just sip the size check at all for those two tests? |
|
Oh, of course, that's why I scratched my head about those failing tests. |
|
I removed the size test in my latest commit, how does it work on your end? |
LinusU
force-pushed
the
master
branch
2 times, most recently
from
20c5666 to
53f6290
Compare
* Big svg files will not have a complete first chunk to check for end tag in the svg, hence it is not possible to use isSvg. * Updated file-type to latest version to get more correct file types. * New test for the more common svg file type. That starts with an xml version and doctype.
|
Sorry for the delay on this... |
This was referenced Oct 14, 2021
Closed
|
This was released as 🚢 2.9.1 |
|
No worries at all. I have been using my workaround and I appreciate the merge, good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.