Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG bug #141

Closed
wants to merge 5 commits into from
Closed

Fix SVG bug #141

wants to merge 5 commits into from

Conversation

whizkid77
Copy link

The bug:

  1. fileType will sometimes preemptively detect svg files as application/xml before isSvg is called. We want it to be more specific.
  2. isSvg requires inspecting the entire file contents, while fileType only requires the first chunk.

The solution:

  1. isSvg is more specific, so move it above the fileType call.
  2. Use the end event rather than data event for the file stream.

@LinusU
Copy link
Collaborator

LinusU commented Oct 14, 2021

Sorry that no one ever took a look at this 😢

This was addressed in #103

@LinusU LinusU closed this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants