Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreakable Items In Shop Config #245

Closed
TheSkilledCat opened this issue Jan 4, 2022 · 5 comments
Closed

Unbreakable Items In Shop Config #245

TheSkilledCat opened this issue Jan 4, 2022 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@TheSkilledCat
Copy link

You can add a features that lets you add a unbreakable: true tag in shop.yml so that swords and tools become unbreakable.

It is easy to add because spigot and minecraft already give a way to do that and it could be fixed with small piece of code.

Thank You and I hope this feature will be added :...)

@TheSkilledCat TheSkilledCat added the enhancement New feature or request label Jan 4, 2022
@rcubedev
Copy link

any update on this? @andrei1058

@ajgeiss0702
Copy link
Collaborator

If there was, there would be something here. I believe the shop is getting a rework at some point, so this might go with that.

@tomkeuper
Copy link
Collaborator

Note to self: Any upgraded tool will take damage over time. Make it configurable or just unbreakable

@tomkeuper tomkeuper added the bug Something isn't working label Feb 16, 2023
@tomkeuper
Copy link
Collaborator

Working on it

tomkeuper added a commit that referenced this issue Feb 20, 2023
@tomkeuper
Copy link
Collaborator

tomkeuper commented Feb 20, 2023

Refresh the config OR add 'is-unbreakable: true' to melee items
image

@andrei1058 andrei1058 mentioned this issue Feb 26, 2023
andrei1058 added a commit that referenced this issue Feb 26, 2023
New features:
- Added {prefix} support to all messages
- Added unformatted player names for kill and bed destroy message
- Added unbreakable to mellee weapons #245
- Addded Elytra auto equip #663
- add toggle for halloween special (#632)
- Added Placeholders to upgrade message #668

For developers:
- add sidebar init event
- exposed sidebar to the API

- fix team identifier length (Sidebar kick issue (#682, #666 )
- Fix Moneys reward team-support on Solo & update variables names
- Bug fixes and placeholder adjustments (#685)
- Fixed command error when lobby location is not set
- Fixed spanish translation error #599
- Fixed spanish translation error #599
- Netherite armor support in 1.16+ #657
- Wins placeholder not in lobby sidebar #658
- Sidebar Title animation not working #660
- Player levels showing numbers #661
- Fixed In-game arena Scoreboard lines in the wrong spot #662
- NPE when clicking outside of shop inventory #664
- Added Placeholders to upgrade message #668
- Fixed players can collect drops during respawn #669

---------

Co-authored-by: Tom Keuper <[email protected]>
Co-authored-by: Yuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants