Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-game arena Scoreboard lines in the wrong spot #662

Closed
Shad0wolf0 opened this issue Feb 6, 2023 · 11 comments · Fixed by andrei1058/SidebarLib#19
Closed

In-game arena Scoreboard lines in the wrong spot #662

Shad0wolf0 opened this issue Feb 6, 2023 · 11 comments · Fixed by andrei1058/SidebarLib#19

Comments

@Shad0wolf0
Copy link

Shad0wolf0 commented Feb 6, 2023 •
edited
Loading

Describe the bug

In-game arena scoreboard lines in the wrong spot. Default lang file, the IP address is on line 3, the events and timer is on line 14.
To Reproduce
Steps to reproduce the behavior:

  1. Install bedwars1058 23.2 with the default config.
  2. Go to the server and join arena
  3. Start arena and look at the scoreboard

Expected behavior

Expected the scoreboard to show correctly whats in the language file.
Screenshots

image

System (please complete the following information):

  • OS: Windows 11
  • Server software: Purpur
  • Server Version: 1.19.3
  • Plugin Version: 23.2

Additional context

Edit: tested with Multiarena mode and it seems to happen to the waiting lobby too when coming from the bedwars lobby.
@Shad0wolf0 Shad0wolf0 added the bug Something isn't working label Feb 6, 2023
@1RLGS
Copy link

1RLGS commented Feb 6, 2023

Have the same problem

@tomkeuper
Copy link
Collaborator

I have not been able to replicate this issue. can you give some more info? and maybe provide a full server log?

@tomkeuper tomkeuper added the needs-reproduction Likely bugs, but haven't been reliably reproduced. label Feb 11, 2023
@Shad0wolf0
Copy link
Author

I used bungeecord but it's still there without it. I don't know what other info I can give.
I attached my log.
latest.log

@tomkeuper
Copy link
Collaborator

tomkeuper commented Feb 13, 2023 •
edited
Loading

Can you attach config and language file used, and maybe try on a clean server? (only bw)
dont forget to remove sensitive info from config

@bandaohana
Copy link

This could be caused by your lang file, check if the scoreboard lines have '
like in this example:
image

@andrei1058
Copy link
Owner

You're not using the latest version

@andrei1058 andrei1058 removed needs-reproduction Likely bugs, but haven't been reliably reproduced. bug Something isn't working labels Feb 17, 2023
@Shad0wolf0
Copy link
Author

Shad0wolf0 commented Feb 17, 2023 •
edited
Loading

I am using the latest version (23.2). I created this issue on a clean server with regenerated config and language files.
config.txt
messages_en.txt

@tomkeuper
Copy link
Collaborator

Try use this version
https://discord.com/channels/201345265821679617/1074361958876315698/1076238139397521418

@andrei1058
Copy link
Owner

Where did you get v23.2 from? this issue used to happen in early builds

@andrei1058 andrei1058 reopened this Feb 17, 2023
@Shad0wolf0
Copy link
Author

I have both of them from spigot and poly and tested them both. I also tested with the latest beta build, but no luck.

@tomkeuper
Copy link
Collaborator

I just tested it with only bedwars and can confirm this issue. It only seems to happen on 1.19 servers and when you join the scoreboard is fine, the lines increment correctly but as soon as the scoreboard changes all lines get value 0 causing the scoreboard to loose format during countdown and also in game

@andrei1058 andrei1058 mentioned this issue Feb 17, 2023
Merged
@tomkeuper tomkeuper mentioned this issue Feb 26, 2023
Merged
@andrei1058 andrei1058 mentioned this issue Feb 26, 2023
Merged
andrei1058 added a commit that referenced this issue Feb 26, 2023
@andrei1058 @tomkeuper @Xxyuri2005xX
Release (#689)
f71953d 
New features:
- Added {prefix} support to all messages
- Added unformatted player names for kill and bed destroy message
- Added unbreakable to mellee weapons #245
- Addded Elytra auto equip #663
- add toggle for halloween special (#632)
- Added Placeholders to upgrade message #668

For developers:
- add sidebar init event
- exposed sidebar to the API

- fix team identifier length (Sidebar kick issue (#682, #666 )
- Fix Moneys reward team-support on Solo & update variables names
- Bug fixes and placeholder adjustments (#685)
- Fixed command error when lobby location is not set
- Fixed spanish translation error #599
- Fixed spanish translation error #599
- Netherite armor support in 1.16+ #657
- Wins placeholder not in lobby sidebar #658
- Sidebar Title animation not working #660
- Player levels showing numbers #661
- Fixed In-game arena Scoreboard lines in the wrong spot #662
- NPE when clicking outside of shop inventory #664
- Added Placeholders to upgrade message #668
- Fixed players can collect drops during respawn #669

---------

Co-authored-by: Tom Keuper <[email protected]>
Co-authored-by: Yuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix team score issue on 1.19 andrei1058/SidebarLib
5 participants
@andrei1058 @tomkeuper @Shad0wolf0 @1RLGS @bandaohana