Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invisibility potion compatibility with 1.8.8 and scoreboard improvements #702

Merged
merged 19 commits into from
Mar 26, 2023
Merged

fix invisibility potion compatibility with 1.8.8 and scoreboard improvements #702

merged 19 commits into from
Mar 26, 2023

Conversation

andrei1058
Copy link
Owner

@andrei1058 andrei1058 commented Mar 5, 2023 •
edited
Loading

fix #688
fix #712
fix #681

@andrei1058 andrei1058 temporarily deployed to development March 5, 2023 20:05 — with GitHub Actions Inactive
@tomkeuper tomkeuper temporarily deployed to development March 5, 2023 21:12 — with GitHub Actions Inactive
@andrei1058 andrei1058 temporarily deployed to development March 11, 2023 14:34 — with GitHub Actions Inactive
@andrei1058 andrei1058 temporarily deployed to development March 11, 2023 14:34 — with GitHub Actions Inactive
@andrei1058 andrei1058 temporarily deployed to development March 11, 2023 14:42 — with GitHub Actions Inactive
@andrei1058 andrei1058 temporarily deployed to development March 11, 2023 14:42 — with GitHub Actions Inactive
@andrei1058 andrei1058 requested a review from tomkeuper March 11, 2023 14:43
@andrei1058
Copy link
Owner Author

I made some changes because the sidebar holder was getting header-footer strings in tab-subject's language. It was also triggering header-footer updade every single time a tab-subject was updated.

@andrei1058 andrei1058 temporarily deployed to development March 11, 2023 14:54 — with GitHub Actions Inactive
@andrei1058 andrei1058 temporarily deployed to development March 11, 2023 14:54 — with GitHub Actions Inactive
@tomkeuper
Copy link
Collaborator

Im quite sure that the only thing that still needs to happen is making he namtag visible again when the player gets out of invis.
as decribed here: https://discord.com/channels/201345265821679617/1074361958876315698/1083653985325551636

@andrei1058
Copy link
Owner Author

Im quite sure that the only thing that still needs to happen is making he namtag visible again when the player gets out of invis. as decribed here: https://discord.com/channels/201345265821679617/1074361958876315698/1083653985325551636

Can't reproduce that
2023-03-12_13 27 58
2023-03-12_13 28 07

@andrei1058 andrei1058 changed the title fix invisibility potion compatibility with 1.8.8 fix invisibility potion compatibility with 1.8.8 and scoreboard improvements Mar 12, 2023
@andrei1058 andrei1058 temporarily deployed to development March 13, 2023 19:04 — with GitHub Actions Inactive
@andrei1058 andrei1058 temporarily deployed to development March 13, 2023 19:04 — with GitHub Actions Inactive
@tomkeuper
Copy link
Collaborator

Did you test on 1.8.8? That where the issue occurs

@tomkeuper tomkeuper temporarily deployed to development March 16, 2023 15:17 — with GitHub Actions Inactive
@tomkeuper tomkeuper temporarily deployed to development March 16, 2023 15:17 — with GitHub Actions Inactive
@tomkeuper tomkeuper temporarily deployed to development March 16, 2023 15:17 — with GitHub Actions Inactive
@tomkeuper
Copy link
Collaborator

How tf did I merge my branch into 668? ugh...

@andrei1058 andrei1058 merged commit a99f3ae into master Mar 26, 2023
@tomkeuper tomkeuper deleted the issue-688 branch March 27, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkeuper tomkeuper Awaiting requested review from tomkeuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andrei1058 @tomkeuper