-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(mdc-progress-bar): Does not flip with body set to dir="rtl"
#22609
Comments
Are you seeing the regression in our own dev app or someplace else? The dev app has a custom |
yeah its an internal test - they just add |
That should work, but I'll double-check. The issue I mentioned above is with our own dev app. |
I gave it another shot, but it worked as expected. We might have to investigate that internal test. |
If you go into the demo app and just add |
The legacy one works, because the flip happens purely in CSS, whereas the MDC one has to execute some JS logic. |
…ge directionality On the first iteration of the MDC progress bar we had to use JS to change the direction in RTL, but a few months ago in angular#21650 we switched to a different API that no longer depends on it. The problem with the changes in angular#21650 is that they set the `dir` on the progress bar in order to flip its direction for the `query` mode. These changes simplify the setup by relying only on CSS to determine the direction. Fixes angular#22609.
I looked into it again and it seems like we've moved away from the MDC API that required us to flip direction using JS. I've submitted #22705 which should resolve this issue. |
…ge directionality (#22705) On the first iteration of the MDC progress bar we had to use JS to change the direction in RTL, but a few months ago in #21650 we switched to a different API that no longer depends on it. The problem with the changes in #21650 is that they set the `dir` on the progress bar in order to flip its direction for the `query` mode. These changes simplify the setup by relying only on CSS to determine the direction. Fixes #22609.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The legacy progress bar has specific styles to flip its directionality based on a parent having
[dir='rtl']
:However, this is missing from the new MDC-based progress bar. Should this extra code be included? An internal test fails due to this case, but perhaps it should have been implemented otherwise through the Directionality service?
The text was updated successfully, but these errors were encountered: