fix(material-experimental/mdc-progress-bar): don't rely on JS to change directionality #22705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge directionality On the first iteration of the MDC progress bar we had to use JS to change the direction in RTL, but a few months ago in angular#21650 we switched to a different API that no longer depends on it. The problem with the changes in angular#21650 is that they set the `dir` on the progress bar in order to flip its direction for the `query` mode. These changes simplify the setup by relying only on CSS to determine the direction. Fixes angular#22609.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
andrewseguin
approved these changes
May 17, 2021
andrewseguin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the first iteration of the MDC progress bar we had to use JS to change the direction in RTL, but a few months ago in #21650 we switched to a different API that no longer depends on it. The problem with the changes in #21650 is that they set the
diron the progress bar in order to flip its direction for thequerymode.These changes simplify the setup by relying only on CSS to determine the direction.
Fixes #22609.