Ensure wrapped ERC20 transfers are correctly authorized and add end-to-end tests for them #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
force-pushed
the
james/ethbridge/e2e-wrapped-erc20-transfers
branch
5 times, most recently
from
9c20e94 to
949421c
Compare
james-chf
force-pushed
the
james/ethbridge/e2e-wrapped-erc20-transfers
branch
from
949421c to
4751573
Compare
sug0
approved these changes
Feb 7, 2023
batconjurer
reviewed
Feb 7, 2023
| verifiers: &BTreeSet<Address>, | ||
| sender: &Address, | ||
| ) -> bool { | ||
| verifiers.contains(sender) |
There was a problem hiding this comment.
honest question, I've always wondered if we trigger the receiver vp as well. Or can people not refuse money from certain accounts?
There was a problem hiding this comment.
It seems we should trigger the receiver account as well.
There was a problem hiding this comment.
Will add this, will require some small refactoring.
batconjurer
reviewed
Feb 7, 2023
batconjurer
requested changes
Feb 7, 2023
…d-erc20-transfers * eth-bridge-integration: Fix the validator set hashes signed over by secp keys
4 tasks
…d-erc20-transfers * eth-bridge-integration: In tests crate, use eth bridge types via shared crate Use namada_ethereum_bridge via shared crate Use (not(feature = "abcipp")) Revert genesis.rs changes Fix up the e2e test Move oracle Config struct to ethereum_bridge crate Rename test Simplify setup::network call slightly Don't set any Ethereum bridge params in dev mode Revert "Remove e2e test until expectrl issue solved" # Conflicts: # tests/src/e2e/eth_bridge_tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #432 and relates to #508
This PR
NB: some helper fns added/used in this PR are also in https://github.com/anoma/namada/pull/886/files#diff-b26bbd416d9d500f8f12aee8f7b3182f35b5cacb748898d9c07fe2cdd41e69b8