Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end tests for wrapped ERC20 transfers between accounts #432

Closed
4 tasks
james-chf opened this issue Sep 2, 2022 · 1 comment · Fixed by #1112
Closed
4 tasks

End-to-end tests for wrapped ERC20 transfers between accounts #432

james-chf opened this issue Sep 2, 2022 · 1 comment · Fixed by #1112

Comments

@james-chf
Copy link
Contributor

james-chf commented Sep 2, 2022

When a balance transfer is carried out, the EthBridge VP should only allow it if the sender of the transfer (i.e. owner of the balance which is being decreased) authorized the transaction.

This issue can be closed when we have tests for the following types of ERC20 transfers (similar to the generic multitoken transfer tests in #886):

  • implicit -> implicit
  • implicit -> established
  • established -> implicit
  • established -> established
@james-chf james-chf moved this to Todo in Namada-Old Sep 2, 2022
@james-chf james-chf changed the title The EthBridge VP should only permit authorized balance transfers The EthBridge VP should only permit authorized balance transfers for established accounts Sep 9, 2022
@james-chf james-chf changed the title The EthBridge VP should only permit authorized balance transfers for established accounts The EthBridge VP should ensure established accounts' VPs are called for transfers Sep 9, 2022
@james-chf james-chf changed the title The EthBridge VP should ensure established accounts' VPs are called for transfers The EthBridge VP should ensure established accounts' VPs guard their transfers Sep 9, 2022
@james-chf james-chf self-assigned this Oct 11, 2022
@james-chf james-chf removed their assignment Oct 11, 2022
@james-chf james-chf changed the title The EthBridge VP should ensure established accounts' VPs guard their transfers The EthBridge VP should ensure only authorized transfers of wrapped ERC20 tokens are permitted Dec 12, 2022
@james-chf
Copy link
Contributor Author

#8 is completed, so have widened the scope of this issue to cover wrapped ERC20 transfers for all accounts, not just established accounts. This issue depends on #578, after which we can specifically have tests for wrapped ERC20 transfers.

@james-chf james-chf self-assigned this Jan 12, 2023
@james-chf james-chf moved this from Todo to WIP in Namada-Old Jan 23, 2023
@james-chf james-chf moved this from WIP to Todo in Namada-Old Jan 23, 2023
@james-chf james-chf changed the title The EthBridge VP should ensure only authorized transfers of wrapped ERC20 tokens are permitted End-to-end tests for wrapped ERC20 transfers between accounts Jan 27, 2023
@james-chf james-chf moved this from Todo to Pending Devnet in Namada-Old Feb 8, 2023
@james-chf james-chf removed their assignment Feb 9, 2023
@github-project-automation github-project-automation bot moved this from Pending Devnet to Tested in Devnet in Namada-Old Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
2 participants