Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter ObjectLockEnabledForBucket to module amazon.aws.s3_bucket #1347

Closed
1 task done
lmilbaum opened this issue Feb 2, 2023 · 5 comments · Fixed by #1372
Closed
1 task done

Add parameter ObjectLockEnabledForBucket to module amazon.aws.s3_bucket #1347

lmilbaum opened this issue Feb 2, 2023 · 5 comments · Fixed by #1372
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@lmilbaum
Copy link
Contributor

lmilbaum commented Feb 2, 2023

Summary

I would like to create s3 bucket with Object Lock Enabled. As of now, AWS doesn't support updating this parameter after the bucket was created unless one reaches AWS support.

Issue Type

Feature Idea

Component Name

s3_bucket

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @abikouo @jillr @s-hertel @tremble

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  module

  module

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Feb 2, 2023

    

  








      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
@lmilbaum Thank you for this feature idea. Would you be willing to take the time and open a pull request for this new option?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @alinabuzachis
alinabuzachis




            added
      

  waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked

    and removed
      

  needs_triage


  labels


      Feb 2, 2023

    

  








      

  
      



  

  @lmilbaum





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

      

      
            lmilbaum
  

      

      

      commented


        Feb 6, 2023


      
    


  





      


        


  
    

      
          


@lmilbaum Thank you for this feature idea. Would you be willing to take the time and open a pull request for this new option?




Will try :-)

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @lmilbaum
lmilbaum



    mentioned this issue
    
      Feb 18, 2023
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Mar 3, 2023
    
    

      


  

    

      


  

      
        @lmilbaum
  





      

        
          s3_bucket: object lock enabled (#1372)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          8aec8f1
        
      

    

  

    

      
s3_bucket: object lock enabled

Depends-On: #1395
SUMMARY
Fixes #1347
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis

    




    

  




  


  
    
  
  

    
  tremble 

      pushed a commit
        to tremble/amazon.aws
      that referenced
      this issue

    
      Mar 3, 2023
    
    

      


  

    

      


  

      
        @lmilbaum
      
        @tremble
  





      

        
          s3_bucket: object lock enabled (ansible-collections#1372)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          ee59b2d
        
      

    

  

    

      
s3_bucket: object lock enabled

Depends-On: ansible-collections#1395
SUMMARY
Fixes ansible-collections#1347
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis

    




    

  




  

  

    
  


  

      

    @tremble
tremble



    mentioned this issue
    
      Mar 3, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Mar 3, 2023
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          s3_bucket: object lock enabled (#1372) (#1407)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          67bc04d
        
      

    

  

    

      
[PR #1372/8aec8f1b backport][stable-5] s3_bucket: object lock enabled

SUMMARY
Fixes #1347
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis

Reviewed-by: Alina Buzachis

    




    

  









      

  
      



  

  @lmilbaum





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

      

      
            lmilbaum
  

      

      

      commented


        Mar 3, 2023


      
    


  





      


        


  
    

      
          
Thank you for giving me the opportunity to contribute to this project.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    
















  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    module

  module
  

    plugins

  plugin (any type)
  

    waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      s3_bucket: object lock enabled

    
      lmilbaum/amazon.aws
    





    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @lmilbaum 
        
          @alinabuzachis 
        
          @ansibullbot