s3_bucket: object lock enabled #1372
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 30s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
lmilbaum
force-pushed
the
1347
branch
2 times, most recently
from
1cf22eb to
54c3045
Compare
There was a problem hiding this comment.
Hi @lmilbaum,
Thanks for taking the time to submit this PR. A couple of things:
- Please add some integration tests (tests/integration/targets/s3_bucket)
- As far as I can tell it should be possible to update the setting, this PR currently only supports setting it on a new bucket.
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
lmilbaum
force-pushed
the
1347
branch
2 times, most recently
from
01e5d95 to
927f5db
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 29s |
lmilbaum
force-pushed
the
1347
branch
2 times, most recently
from
8f3f509 to
f4e0335
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 03s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 17s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 53s |
Hi @tremble. Thank you for your feedback. I am new to this project and therefor moving forward step by step. |
|
recheck - command to CI (we're having problems with CI at the minute) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 55s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 18s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 43s |
|
Build failed. ❌ ansible-galaxy-importer RETRY_LIMIT in 7m 11s |
tremble
added
mergeit
|
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/15eb46e51f994c61a8ff03bf5366beec ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 43s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
tremble
added
mergeit
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 00s |
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 8aec8f1 on top of patchback/backports/stable-5/8aec8f1b007eba9cafe6f8a7fb0a993a2991b58f/pr-1372 Backporting merged PR #1372 into main
🤖 @patchback |
s3_bucket: object lock enabled Depends-On: ansible-collections#1395 SUMMARY Fixes ansible-collections#1347 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
aws_region_info - Minor docs linting SUMMARY Nudge a module to trigger the sanity tests ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_region_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
aws_region_info - Minor docs linting SUMMARY Nudge a module to trigger the sanity tests ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_region_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
aws_region_info - Minor docs linting SUMMARY Nudge a module to trigger the sanity tests ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_region_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@41c7dd0
aws_region_info - Minor docs linting SUMMARY Nudge a module to trigger the sanity tests ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_region_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@41c7dd0
aws_region_info - Minor docs linting SUMMARY Nudge a module to trigger the sanity tests ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_region_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@41c7dd0
aws_region_info - Minor docs linting SUMMARY Nudge a module to trigger the sanity tests ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_region_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Depends-On: #1395
SUMMARY
Fixes #1347
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION