Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup_aws_account_attribute integration test broken #633

Closed
1 task done
tremble opened this issue Jan 22, 2022 · 3 comments · Fixed by #810
Closed
1 task done

lookup_aws_account_attribute integration test broken #633

tremble opened this issue Jan 22, 2022 · 3 comments · Fixed by #810
Labels
bug This issue/PR relates to a bug has_pr jira needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_verified Some one might want to take a look at this and reproduce it to confirm traceback

Comments

@tremble
Copy link
Contributor

tremble commented Jan 22, 2022

Summary

After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running wantlist=False

Test disabled by #632

Issue Type

CI Bug Report

CI Jobs

https://ansible.softwarefactory-project.io/zuul/build/34f3d65186154e3cb68c932c3fdc02e0/logs

Pull Request

#630

Additional Information

TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] *******************************************************************************************************************************
task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50
The full traceback is:
Traceback (most recent call last):
  File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute
    self._task.post_validate(templar=templar)
  File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate
    super(Task, self).post_validate(templar)
  File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate
    value = templar.template(getattr(self, name))
  File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template
    d[k] = self.template(
  File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template
    result = self.do_template(
  File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template
    res = ansible_concat(rf, convert_data, myenv.variable_start_string)
  File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat
    head = list(islice(nodes, 2))
  File "<template>", line 13, in root
  File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call
    return __obj(*args, **kwargs)
  File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup
    if isinstance(ran[0], NativeJinjaText):
KeyError: 0
fatal: [testhost]: FAILED! => {
    "changed": false
}

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble
Copy link
Contributor Author

tremble commented Jan 22, 2022

It's possible / probably that this is a bug in ansible/ansible. However, I can't see an existing issue and I'd hope we're not the only ones testing wantlist=False. As such there's probably "something" that the module is doing that needs hunting down for an issue to bu raised in ansible/ansible

@ansibullbot
Copy link

@tremble: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage traceback labels Jan 27, 2022
@jillr jillr added jira needs_verified Some one might want to take a look at this and reproduce it to confirm and removed needs_triage labels Feb 8, 2022
@jatorcasso
Copy link
Contributor

closing and moving to ansible/ansible ansible/ansible#77788

softwarefactory-project-zuul bot pushed a commit that referenced this issue Jun 30, 2022
lookup_aws_account_attribute - re-enable integration tests

SUMMARY
Presented a fix in ansible/ansible ansible/ansible#77789
Won't be merged until milestone branch gets updated 2022-06-27
Fixes #633
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lookup_aws_account_attribute

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug has_pr jira needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_verified Some one might want to take a look at this and reproduce it to confirm traceback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants