Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_endpoint - Remove policy_file parameter #1195

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 24, 2022

SUMMARY

fixes: #1178

Drops the previously deprecated policy_file parameter.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_endpoint

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) tests tests labels Oct 24, 2022
@github-actions
Copy link

github-actions bot commented Oct 24, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 00s
✔️ build-ansible-collection SUCCESS in 6m 00s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 23s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 26s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 36s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 38s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 15s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 14s
✔️ cloud-tox-py3 SUCCESS in 3m 04s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-amazon.aws-1 SUCCESS in 11m 09s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 20s

@tremble tremble marked this pull request as ready for review October 24, 2022 12:56
@tremble tremble requested a review from alinabuzachis October 24, 2022 12:56
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Oct 24, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 55s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 07s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 02s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 03s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 53s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 26s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 28s
✔️ cloud-tox-py3 SUCCESS in 4m 03s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-amazon.aws-1 SUCCESS in 11m 25s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 35fd507 into ansible-collections:main Oct 24, 2022
@tremble tremble deleted the deprecation/remove/6.0.0/ec2_vpc_endpoint branch February 15, 2023 09:01
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…tions#1195)

SUMMARY

Add region detection to skip usage of FIFO topics when using GovCloud regions
Fixes ansible-collections#836
ISSUE TYPE

    Bugfix Pull Request

COMPONENT NAME

community.aws.sns_topic


* * Add endpoint detection to skip usage of FIFO topics for GovCloud regions
* * Remove GovCloud hack for FIFO topics
* Update plugins/modules/sns_topic.py
* Update plugins/modules/sns_topic.py
* minor docs tweak
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…tions#1195)

SUMMARY

Add region detection to skip usage of FIFO topics when using GovCloud regions
Fixes ansible-collections#836
ISSUE TYPE

    Bugfix Pull Request

COMPONENT NAME

community.aws.sns_topic


* * Add endpoint detection to skip usage of FIFO topics for GovCloud regions
* * Remove GovCloud hack for FIFO topics
* Update plugins/modules/sns_topic.py
* Update plugins/modules/sns_topic.py
* minor docs tweak
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…tions#1195)

SUMMARY

Add region detection to skip usage of FIFO topics when using GovCloud regions
Fixes ansible-collections#836
ISSUE TYPE

    Bugfix Pull Request

COMPONENT NAME

community.aws.sns_topic


* * Add endpoint detection to skip usage of FIFO topics for GovCloud regions
* * Remove GovCloud hack for FIFO topics
* Update plugins/modules/sns_topic.py
* Update plugins/modules/sns_topic.py
* minor docs tweak
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Add missing changelog fragment for 1195

SUMMARY
Forgot to add a changelog fragment for ansible-collections#1195
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6.0.0] ec2_vpc_endpoint - remove deprecated policy_file parameter
3 participants