[PR #826/944bb1fe backport][stable-3] inventory aws_ec2 - allow for literal strings in hostnames #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
inventory aws_ec2 - allow for literal strings in hostnames SUMMARY Allow for literal strings in hostnames rather than throwing an AnsibleError Fixes #814 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Is there a better way of allowing for literal strings here? Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> (cherry picked from commit 944bb1f)
ansibullbot
added
community_review
feature
jatorcasso
approved these changes
May 24, 2022
jillr
approved these changes
May 24, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/944bb1feed6bc6ec8203a7ec9532607e7d51d197/pr-826
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tions#1195) SUMMARY Add region detection to skip usage of FIFO topics when using GovCloud regions Fixes ansible-collections#836 ISSUE TYPE Bugfix Pull Request COMPONENT NAME community.aws.sns_topic * * Add endpoint detection to skip usage of FIFO topics for GovCloud regions * * Remove GovCloud hack for FIFO topics * Update plugins/modules/sns_topic.py * Update plugins/modules/sns_topic.py * minor docs tweak
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tions#1195) SUMMARY Add region detection to skip usage of FIFO topics when using GovCloud regions Fixes ansible-collections#836 ISSUE TYPE Bugfix Pull Request COMPONENT NAME community.aws.sns_topic * * Add endpoint detection to skip usage of FIFO topics for GovCloud regions * * Remove GovCloud hack for FIFO topics * Update plugins/modules/sns_topic.py * Update plugins/modules/sns_topic.py * minor docs tweak
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…tions#1195) SUMMARY Add region detection to skip usage of FIFO topics when using GovCloud regions Fixes ansible-collections#836 ISSUE TYPE Bugfix Pull Request COMPONENT NAME community.aws.sns_topic * * Add endpoint detection to skip usage of FIFO topics for GovCloud regions * * Remove GovCloud hack for FIFO topics * Update plugins/modules/sns_topic.py * Update plugins/modules/sns_topic.py * minor docs tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #826 as merged into main (944bb1f).
SUMMARY
Allow for literal strings in hostnames rather than throwing an AnsibleError
Fixes #814
ISSUE TYPE
COMPONENT NAME
aws_ec2
ADDITIONAL INFORMATION
Is there a better way of allowing for literal strings here?