Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions #1552

Merged
merged 2 commits into from
May 17, 2023
Merged

inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions #1552

merged 2 commits into from
May 17, 2023

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 16, 2023

SUMMARY

fixes: #1551

If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions...

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_ec2 inventory plugin

ADDITIONAL INFORMATION

Nominally botocore should be falling back to a default region, but there are no guarantees

@tremble tremble added the backport-6 PR should be backported to the stable-6 branch label May 16, 2023
@tremble tremble mentioned this pull request May 16, 2023
Closed
1 task
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9118b910f3be49bf9f44338ed5e4a44d

✔️ ansible-galaxy-importer SUCCESS in 4m 51s
✔️ build-ansible-collection SUCCESS in 13m 17s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-amazon.aws-1 SUCCESS in 16m 30s
Skipped 43 jobs

@tremble tremble marked this pull request as ready for review May 16, 2023 15:27
@tremble tremble requested a review from alinabuzachis May 16, 2023 15:27
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 17, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a282fa2e400046c4837a6cee6c5e6d1e

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-splitter SUCCESS in 5m 02s
✔️ integration-amazon.aws-1 SUCCESS in 15m 47s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c992070 into ansible-collections:main May 17, 2023
@patchback
Copy link

patchback bot commented May 17, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/c992070153f3d31fae61c7b91dd52a41e276ffef/pr-1552

Backported as #1556

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2023
@tremble @patchback
inventory plugins - Hard code fall-back region to connect to when try…
97c51d5 
…ing to pull a list of regions (#1552)

inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions

SUMMARY
fixes: #1551
If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions...
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
aws_ec2 inventory plugin
ADDITIONAL INFORMATION
Nominally botocore should be falling back to a default region, but there are no guarantees

Reviewed-by: Alina Buzachis
(cherry picked from commit c992070)
@patchback patchback bot mentioned this pull request May 17, 2023
Merged
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 17, 2023
@patchback
inventory plugins - Hard code fall-back region to connect to when try…
a71c207 
…ing to pull a list of regions (#1552) (#1556)

[PR #1552/c9920701 backport][stable-6] inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions

This is a backport of PR #1552 as merged into main (c992070).
SUMMARY
fixes: #1551
If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions...
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
aws_ec2 inventory plugin
ADDITIONAL INFORMATION
Nominally botocore should be falling back to a default region, but there are no guarantees

Reviewed-by: Mark Chappell
@tremble tremble deleted the issues/1551 branch September 27, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2 inventory plugin does not work without region or regions field
2 participants
@tremble @alinabuzachis