Add assume role functionality to aws_rds #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably this shared functionality would be better to put in a shared module, as I've mostly just duplicated code. But still I think this is a useful first step.
|
I forgot to mention that this would resolve issue #30 |
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've basically copied the relevant functions from
aws_ec2.py, there's nothing really new in here.Probably this shared functionality would be better to put in a shared module, as I've mostly just duplicated code. But still I think this is a useful first step.
SUMMARY
Carry over the asume role functionality from aws_ec2.py
ISSUE TYPE
COMPONENT NAME
aws_rds
ADDITIONAL INFORMATION
As I said above, I think there's some shared functionality between the EC2 and RDS inventory plugins that could be extracted into a shared module. I didn't want to make too many changes in the code, and as there was already some duplication between the two plugins, so I basically followed what was already there. i'd be happy to refactor this a bit, please let me know if that would be appreciated.