feat(261): Adds parameter to descend into lists when scrubbing None p… #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
requested changes
Feb 9, 2021
2 tasks
jillr
reviewed
Mar 1, 2021
There was a problem hiding this comment.
Hi @winmat, thanks very much for the work starting this. Are you able to continue working on this PR or would you mind if someone continued with it? This would solve a few bugs so I'd like to be sure we can get it released asap.
|
Hi @wimnat, we've not heard from you in a while, since we've multiple PRs currently on hold for this I've attempted to address the various comments. I hope you don't mind. |
tremble
approved these changes
Mar 9, 2021
felixfontein
approved these changes
Mar 9, 2021
jillr
approved these changes
Mar 9, 2021
|
@tremble I'm happy for this to merge once CI is green, reran it a few times |
|
Hmm, according to Zuul, the stable-2.9 pylint sanity test is failling: |
ansibullbot
added
community_review
and removed
needs_revision
|
@felixfontein Yeah, the stable-2.9 sanity tests have been fixed by #296 and #294 (unrelated to this PR, I'm guessing something was updated in the stable-2.9 container with the latest releases) Tests are now passing in shippable, so I'm going to merge |
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arams
SUMMARY
Fixes #261
Adding parameter to descend in to lists when scrubbing None parameter
ISSUE TYPE
COMPONENT NAME
scrub_none_parameters helper function (core)
ADDITIONAL INFORMATION
Defaulting to True as not yet implemented anywhere