Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore duplicate-except pylint errors #294

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 9, 2021

SUMMARY

There's a known issue with pylint not understanding the logic we're using. Explicitly ignore

duplicate-except: Catching previously caught exception type ClientError (0%)

Where we're using is_boto3_error_code

ISSUE TYPE
  • Tests Pull Request
COMPONENT NAME

plugins/modules/aws_s3.py
plugins/modules/ec2_ami.py
plugins/modules/ec2_eni_info.py
plugins/modules/ec2_key.py
plugins/modules/s3_bucket.py

ADDITIONAL INFORMATION

Pylint issue: pylint-dev/pylint#2174

@ansibullbot ansibullbot added community_review module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Mar 9, 2021
@tremble tremble requested review from jillr and alinabuzachis March 9, 2021 19:47
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tremble . LGTM.

@jillr jillr merged commit 02f6d50 into ansible-collections:main Mar 9, 2021
@tremble tremble deleted the sanity/duplicate-except branch May 28, 2021 07:08
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…buting

Add some extra links to the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants